Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress visualisation not working, gives an error #40658

Closed
notrom opened this issue Mar 27, 2024 · 3 comments · Fixed by #41330
Closed

Progress visualisation not working, gives an error #40658

notrom opened this issue Mar 27, 2024 · 3 comments · Fixed by #41330
Assignees
Labels
.Frontend Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Team/DashViz Dashboard and Viz team Type:Bug Product defects Visualization/Scalars Numbers, progress bars, gauges
Milestone

Comments

@notrom
Copy link

notrom commented Mar 27, 2024

Describe the bug

I create a simple question returning a single count value, this previews in the notebook mode, and displays a number correctly when visualised. When I change it to a Progress visualisation I get the exclamation mark displayed instead. I then can't change back to a number or table, I need to refresh or start a new question.

To Reproduce

  1. Create a new question
  2. Sample Database > Accounts
  3. Count of rows
    image
  4. Visualise, Number is presented as expected
    image
  5. Change the visualisation type to "Progress", error occurs
    image
  6. Can't change to any other type of visualisation, need to restart
  7. Can't use the data/visualisation slider to view the raw data either

Expected behavior

Progress chart to be displayed and I can continue to work on the question.

Logs

JavaScript console:

TypeError: Cannot read properties of undefined (reading 'height')
    at oy.componentDidUpdate (Progress.jsx:100:39)
    at oy.componentDidMount (Progress.jsx:86:10)
    at react-dom.production.min.js:212:132
    at a$ (react-dom.production.min.js:213:322)
    at t.unstable_runWithPriority (scheduler.production.min.js:19:467)
    at on (react-dom.production.min.js:122:325)
    at aX (react-dom.production.min.js:248:370)
    at aW (react-dom.production.min.js:239:376)
    at react-dom.production.min.js:123:115
    at t.unstable_runWithPriority (scheduler.production.min.js:19:467)

Information about your Metabase installation

{
  "browser-info": {
    "language": "en-NZ",
    "platform": "Win32",
    "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "Cp1252",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "17.0.2+8",
    "java.vendor": "Eclipse Adoptium",
    "java.vendor.url": "https://adoptium.net/",
    "java.version": "17.0.2",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "17.0.2+8",
    "os.name": "Windows 10",
    "os.version": "10.0",
    "user.language": "en",
    "user.timezone": "Pacific/Auckland"
  },
  "metabase-info": {
    "databases": [
      "sqlserver",
      "h2",
      "postgres"
    ],
    "hosting-env": "unknown",
    "application-database": "postgres",
    "application-database-details": {
      "database": {
        "name": "PostgreSQL",
        "version": "12.1"
      },
      "jdbc-driver": {
        "name": "PostgreSQL JDBC Driver",
        "version": "42.7.2"
      }
    },
    "run-mode": "prod",
    "version": {
      "date": "2024-03-21",
      "tag": "v0.49.1",
      "hash": "54ef5e9"
    },
    "settings": {
      "report-timezone": "Pacific/Auckland"
    }
  }
}

Severity

Can't create progress bars at all. We don't use them much so not a big issue for me.

Additional context

Also and issue in Firefox.

I don't get this on v0.48.6, progress bars are working as expected.

@notrom notrom added .Needs Triage Type:Bug Product defects labels Mar 27, 2024
@notrom
Copy link
Author

notrom commented Mar 27, 2024

Interestingly I can go ahead and save the question in that state, it still fails to render. I can then add it to a dashboard and it will render, but clicking the title to open it goes back to the error screen.
image

@ranquild ranquild added Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Frontend Visualization/Scalars Numbers, progress bars, gauges and removed .Needs Triage labels Mar 27, 2024
@paoliniluis paoliniluis added Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. and removed Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness labels Mar 27, 2024
@paoliniluis
Copy link
Contributor

Lowering to p2

@alxnddr alxnddr added the .Team/DashViz Dashboard and Viz team label Mar 27, 2024
@NicolasPA
Copy link

I confirm this issue and the fact that it still renders in dashboard on v0.49.2.

This was referenced May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Team/DashViz Dashboard and Viz team Type:Bug Product defects Visualization/Scalars Numbers, progress bars, gauges
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants