SQL field, table and schema matching

[piranha]

Uses new Macaw to better match Field objects used in an SQL string.

References #36911

[tsmacdonald]

Compelling tests

[tsmacdonald]

Looks nice to me!

You've confirmed that our understanding of case and quotes is true for all SQL dialects we care about?

[piranha]

You've confirmed that our understanding of case and quotes is true for all SQL dialects we care about?

Ehmm... it's a bit shameful, but I've looked at list of supported databases and just asked ChatGPT. It says that most of dialects support SQL Standard - so unquoted names are case insensitive, quoted are case sensitive.

[replay-io]

Status	Complete ↗︎
Commit	48c4945
Results	⚠️ 6 Flaky ✅ 2430 Passed

[tsmacdonald]

this is indeed perverse :)

[tsmacdonald]

Oh nice, the tests are legit broken with the case-matching, I think:

FAIL in metabase.models.query-field-test/table-wildcard-test (query_field_test.clj:127)

with temporary :model/Card with attributes
{:creator_id 1,
 :database_id 1,
 :dataset_query {:type :native, :native {:query "SELECT NOT_TAX, TOTAL FROM orders"}, :database 1},
 :display :table,
 :name "OHFYZTENFEEYTCUGLAQY",
 :visualization_settings {},
 :created_at #t "2024-04-25T06:38:59.146814Z[UTC]",
 :updated_at #t "2024-04-25T06:38:59.146815Z[UTC]"}

 mix of select table.* and named columns
expected: 17
  actual: 16

[piranha]

Oh nice, the tests are legit broken with the case-matching, I think:

yeah and it actually had your comment about o.id being wrongly guessed, so we've got our results in line. :)

[github-actions]

@piranha Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?