MLv2: Simplify MetadataProvider protocols (16 methods/3 protocols => 7 methods/2 protocols) #42070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bshepherdson
approved these changes
May 1, 2024
| @@ -256,6 +268,10 @@ | |||
| [:description {:optional true} [:maybe ::lib.schema.common/non-blank-string]]]) | |||
|
|
|||
| (mr/def ::legacy-metric | |||
| "Malli schema for a legacy v1 [[metabase.models.legacy-metric]], but with kebab-case keys. A Metric defines an MBQL | |||
| snippet with an aggregation and optionally a filter clause. You can add a `:metric` reference to the `:aggregations` | |||
There was a problem hiding this comment.
Should that be :legacy-metric?
There was a problem hiding this comment.
It's talking about :metric clauses which are still called :metric AFAIK even if they are V1 metrics
|
@camsaul Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetadataProviderandBulkMetadataProviderprotocols into 5 methods in a single protocol -- instead of separate methods to fetch a Field/Card/Table/LegacyMetric/Segment as well as a bulk method, just have the metadata providers implement only the bulk method and add helper functions for fetching single objects of different typescached-databaseandstore-database!methods from theCachedMetadataProviderprotocollib.metadata/LegacyMetricMetadatato the schema keywords e.g.::lib.schema.metadata/legacy-metric