Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLv2: Simplify MetadataProvider protocols (16 methods/3 protocols => 7 methods/2 protocols) #42070

Merged
merged 18 commits into from
May 3, 2024
Merged

MLv2: Simplify MetadataProvider protocols (16 methods/3 protocols => 7 methods/2 protocols) #42070

merged 18 commits into from
May 3, 2024

Commits on Apr 30, 2024

  1. Simplified MetadataProvider protocol

    @camsaul
    camsaul committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    479cf9a View commit details
    Browse the repository at this point in the history

  2. Test fix

    @camsaul
    camsaul committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d7e49d4 View commit details
    Browse the repository at this point in the history

  3. Ok make CachedMetadataProvider a separate schema again after all.

    @camsaul
    camsaul committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1c0289c View commit details
    Browse the repository at this point in the history

  4. Consolidate the Metadata schemas

    @camsaul
    camsaul committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    bd5ebe1 View commit details
    Browse the repository at this point in the history

  5. Clean Kondo warnings

    @camsaul
    camsaul committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c1eeb83 View commit details
    Browse the repository at this point in the history

  6. Malli-ify the stuff in metabase.lib.metadata.protocols

    @camsaul
    camsaul committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ee0c621 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into simplified-MetadataProvider-protocol

    @camsaul
    camsaul committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c5913d2 View commit details
    Browse the repository at this point in the history

  8. Fix Kondo warnings

    @camsaul
    camsaul committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    88d5ba2 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Test fix 🔧

    @camsaul
    camsaul committed May 1, 2024
    Configuration menu
    Copy the full SHA
    3b3f5d7 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Merge branch 'master' into simplified-MetadataProvider-protocol

    @camsaul
    camsaul committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d3e68b4 View commit details
    Browse the repository at this point in the history

  2. PR feedback

    @camsaul
    camsaul committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b83ed26 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into simplified-MetadataProvider-protocol

    @camsaul
    camsaul committed May 2, 2024
    Configuration menu
    Copy the full SHA
    c4c35e4 View commit details
    Browse the repository at this point in the history

  4. Update the invocation tracker metadata provider

    @camsaul
    camsaul committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3c209de View commit details
    Browse the repository at this point in the history

  5. Remove stray newline

    @camsaul
    camsaul committed May 2, 2024
    Configuration menu
    Copy the full SHA
    85f47e5 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Test fix 🔧

    @camsaul
    camsaul committed May 3, 2024
    Configuration menu
    Copy the full SHA
    cc35019 View commit details
    Browse the repository at this point in the history

  2. throw-if-called! is not allowed inside parallel tests!

    @camsaul
    camsaul committed May 3, 2024
    Configuration menu
    Copy the full SHA
    62d41fc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into simplified-MetadataProvider-protocol

    @camsaul
    camsaul committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7971022 View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @camsaul
    camsaul committed May 3, 2024
    Configuration menu
    Copy the full SHA
    c549aa6 View commit details
    Browse the repository at this point in the history