Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove snippets from search types #42315

Merged
merged 3 commits into from
May 7, 2024

Conversation

kamilmielnik
Copy link
Contributor

Description

Snippets are not supported in search API, see:

(def model-to-db-model
"Mapping from string model to the Toucan model backing it."
{"action" {:db-model :model/Action :alias :action}
"card" {:db-model :model/Card :alias :card}
"collection" {:db-model :model/Collection :alias :collection}
"dashboard" {:db-model :model/Dashboard :alias :dashboard}
"database" {:db-model :model/Database :alias :database}
"dataset" {:db-model :model/Card :alias :card}
"indexed-entity" {:db-model :model/ModelIndexValue :alias :model-index-value}
"metric" {:db-model :model/LegacyMetric :alias :metric}
"segment" {:db-model :model/Segment :alias :segment}
"table" {:db-model :model/Table :alias :table}})

How to verify

TS check is all green.

- They're not supported, see model-to-db-model in search/config.clj
@kamilmielnik kamilmielnik marked this pull request as ready for review May 7, 2024 08:21
@kamilmielnik kamilmielnik added the no-backport Do not backport this PR to any branch label May 7, 2024
@kamilmielnik kamilmielnik requested review from a team and iethree May 7, 2024 08:22
This was referenced May 7, 2024
Copy link

replay-io bot commented May 7, 2024

Status Complete ↗︎
Commit d8ea743
Results
⚠️ 11 Flaky
2460 Passed

@kamilmielnik kamilmielnik merged commit 18313cd into master May 7, 2024
191 of 222 checks passed
@kamilmielnik kamilmielnik deleted the fix/remove-snippets-from-search-types branch May 7, 2024 12:50
Copy link
Contributor

github-actions bot commented May 7, 2024

@kamilmielnik Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@kamilmielnik kamilmielnik added this to the 0.50 milestone May 7, 2024
oisincoveney pushed a commit that referenced this pull request May 8, 2024
* Remove snippets in search models
- They're not supported, see model-to-db-model in search/config.clj

* Fix TS error

* Fix TS error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/Querying
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants