Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly show parent DBs in entity picker recents and search #43016

Merged
merged 1 commit into from
May 23, 2024

Conversation

iethree
Copy link
Contributor

@iethree iethree commented May 22, 2024

Closes #42978

Description

Tables were showing up in recents and search as part of "our analytics" which is ... not true.

Before After
332575086-3fcc27a7-644e-4d14-b629-366eeb5199cb Screen Shot 2024-05-22 at 8 26 41 AM Screen Shot 2024-05-22 at 8 26 32 AM

This also allows recent collection items to show their parent collection. This was previously disabled because search collection items have themselves populated as their parent 🥴. This adds a more sophisticated check and hides only non-sensical collection parents (from the search API). see: #42979

Checklist

  • Tests have been added/updated to cover changes in this PR

@iethree iethree requested review from kamilmielnik and a team May 22, 2024 15:34
@iethree iethree self-assigned this May 22, 2024
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label May 22, 2024
Copy link

replay-io bot commented May 22, 2024

Status In Progress ↗︎ 57 / 58
Commit 12374a1
Results
⚠️ 2 Flaky
2571 Passed

@iethree iethree added the backport Automatically create PR on current release branch on merge label May 22, 2024
Copy link
Contributor

@kamilmielnik kamilmielnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iethree iethree merged commit eee1c7e into master May 23, 2024
135 of 147 checks passed
@iethree iethree deleted the entity-picker/table-parents branch May 23, 2024 11:32
metabase-bot bot added a commit that referenced this pull request May 23, 2024
…#43062)

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data picker search shows tables in "our analytics" instead of in db/schema
2 participants