Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRU card events will log recent-views, and get returned through the API #43037

Merged
merged 23 commits into from
May 30, 2024

Conversation

escherize
Copy link
Contributor

@escherize escherize commented May 22, 2024

Resolves: #42913

All card events for CRU (not D) will log recent-views, and get returned through the API.

@escherize escherize requested a review from camsaul as a code owner May 22, 2024 20:35
@escherize escherize requested a review from a team May 22, 2024 20:35
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label May 22, 2024
Copy link

replay-io bot commented May 22, 2024

Status Complete ↗︎
Commit b75cf6f
Results
3 Failed
⚠️ 3 Flaky
2569 Passed

@escherize escherize changed the title All card events for CRU (not D) will log recent-views, and get returned through the API. CRU card events will log recent-views, and get returned through the API May 22, 2024
@escherize escherize added the no-backport Do not backport this PR to any branch label May 22, 2024
Copy link
Contributor

@johnswanson johnswanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple stray .onlys in e2e tests that I think should be removed

e2e/test/scenarios/question/new.cy.spec.js Outdated Show resolved Hide resolved
@escherize escherize merged commit 3b2736c into master May 30, 2024
110 checks passed
@escherize escherize deleted the more-recent-views-card-events branch May 30, 2024 17:05
Copy link
Contributor

@escherize Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add recent views for Cards
2 participants