Use table2 icon for questions #43095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iethree
added
the
backport
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff a431223...0db02b8.
|
|
mazameli
approved these changes
May 23, 2024
iethree
force-pushed
the
sort-out-table-icons
branch
from
d0cb187
to
0db02b8
Compare
iethree
commented
May 24, 2024
| @@ -33,7 +33,7 @@ export const HomePopularSection = (): JSX.Element => { | |||
| <HomeModelCard | |||
| key={index} | |||
| title={getName(item)} | |||
| icon={getIcon(item, { variant: "secondary" })} | |||
There was a problem hiding this comment.
we no longer need this dumb "secondary" icon concept because its only purpose was to differentiate db tables from questions
iethree
commented
May 24, 2024
| @@ -60,7 +60,7 @@ interface TableState { | |||
| class Table extends Component<TableProps, TableState> { | |||
| static uiName = t`Table`; | |||
| static identifier = "table"; | |||
| static iconName = "table"; | |||
There was a problem hiding this comment.
this is the only "real" change in this PR
sloansparger
approved these changes
May 28, 2024
|
@iethree Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
github-actions bot
pushed a commit
that referenced
this pull request
May 28, 2024
* use table2 icon for questions * update e2e tests
iethree
added a commit
that referenced
this pull request
May 29, 2024
* use table2 icon for questions * update e2e tests
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
discussion
Makes database tables easier to differentiate from questions with a table visualization by using the
table2icon for questions.