Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bars width when chart has two y-axes #43100

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

alxnddr
Copy link
Member

@alxnddr alxnddr commented May 24, 2024

Description

Bar widths are not computed correctly when charts have two y-axes.

How to verify

  • Create a bar chart with >=3 series and two y-axes
  • Ensure bar widths are the same as they would be on a single y-axis chart

Demo

One y-axis:

Screenshot 2024-05-23 at 8 53 11 PM

Two y-axes:

Screenshot 2024-05-23 at 8 52 27 PM

Two y-axes before:

Screenshot 2024-05-23 at 9 00 44 PM

Checklist

  • Tests have been added/updated to cover changes in this PR

@alxnddr alxnddr added the backport Automatically create PR on current release branch on merge label May 24, 2024
@metabase-bot metabase-bot bot added the .Team/DashViz Dashboard and Viz team label May 24, 2024
@alxnddr alxnddr requested a review from a team May 24, 2024 00:07
Copy link

replay-io bot commented May 24, 2024

Status Complete ↗︎
Commit fb00a95
Results
⚠️ 1 Flaky
2575 Passed

@alxnddr alxnddr merged commit 9194a1b into master May 24, 2024
120 of 139 checks passed
@alxnddr alxnddr deleted the fix-thin-bars-when-two-y-axes branch May 24, 2024 15:29
Copy link
Contributor

@alxnddr Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

metabase-bot bot added a commit that referenced this pull request May 24, 2024
Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge .Team/DashViz Dashboard and Viz team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants