Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(temporary branch) Add skeletons to Browse models #43979

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented Jun 10, 2024

Adds skeletons to the table of models and the Recents grid above it

image

@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label Jun 10, 2024
@rafpaf rafpaf changed the base branch from mantine-skeletons to better-skeletons June 11, 2024 15:16
Copy link
Contributor Author

rafpaf commented Jun 11, 2024

:hover { background-color: unset ! important; }
td { cursor: unset ! important; }
`
: `cursor: pointer;`}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also use pointer-events: none;

@rafpaf rafpaf changed the title [Browse] Add skeletons to Browse models (prototype) [Browse] Add skeletons to Browse models Jun 11, 2024
@rafpaf rafpaf force-pushed the browse/skeletons branch 3 times, most recently from b81284e to 61e4544 Compare June 12, 2024 14:01
@rafpaf rafpaf force-pushed the better-skeletons branch 2 times, most recently from 157905a to d1da60e Compare June 12, 2024 14:16
@rafpaf rafpaf changed the title (prototype) [Browse] Add skeletons to Browse models [Browse] Add skeletons to Browse models Jun 12, 2024
@rafpaf rafpaf requested a review from a team June 12, 2024 17:07
@rafpaf rafpaf marked this pull request as ready for review June 12, 2024 17:09
@rafpaf rafpaf merged commit f0fc629 into better-skeletons Jun 12, 2024
142 of 144 checks passed
@rafpaf rafpaf deleted the browse/skeletons branch June 12, 2024 17:09
Copy link

graphite-app bot commented Jun 12, 2024

Graphite Automations

"Warn authors when publishing large PRs" took an action on this PR • (06/12/24)

1 teammate was notified to this PR based on Raphael Krut-Landau's automation.

Copy link

replay-io bot commented Jun 12, 2024

Status Complete ↗︎
Commit f2c480c
Results
⚠️ 3 Flaky
2628 Passed

@rafpaf rafpaf changed the title [Browse] Add skeletons to Browse models (temporary branch) Add skeletons to Browse models Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant