fix: populate param-fields for named fields on public dashboards #44440
+210
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o' into 44231-param-fields-2
…nto 44231-param-fields-2
ranquild
approved these changes
Jun 19, 2024
ranquild
added
the
backport
ranquild
reviewed
Jun 19, 2024
src/metabase/models/params.clj
Outdated
| ;; for mbql queries. | ||
| (lib.util.match/match-one field-clause [:field (id :guard integer?) _] id) | ||
| ;; Attempt to get the field clause from the model metadata corresponding to the field. | ||
| ;; This is the common case for native queries in which mappings from original columns |
There was a problem hiding this comment.
We don't allow mapping between parameters and native models now. This is actually needed for mbql models because they have string-based refs and the above condition with integer? doesn't work. Maybe it's worth updating the comment
|
bshepherdson
approved these changes
Jun 19, 2024
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #44231