Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make preinstall work again (fixes docker build) #4508

Merged
merged 1 commit into from
Mar 21, 2017
Merged

Make preinstall work again (fixes docker build) #4508

merged 1 commit into from
Mar 21, 2017

Conversation

wvengen
Copy link
Contributor

@wvengen wvengen commented Mar 9, 2017

Building the Docker image failed because Busybox doesn't support the ps argument used in preinstall.

Also, the yarn check always failed actually, because $PPID is the shell, not yarn. This fixed both.

(a failed and succeeded build)

@wvengen wvengen changed the title Make preinstall work again (and also with Busybox) Make preinstall work again (fixes docker build) Mar 9, 2017
@huksley
Copy link

huksley commented Mar 9, 2017

Another possible solution is to install procps alpine package before running bin/build.

@wvengen
Copy link
Contributor Author

wvengen commented Mar 13, 2017

@huksley thanks, that may indeed provide a better ps. Nevertheless, the check would still be broken, as the ppid isn't (or not guarenteed to be) the package manager, but a shell spawned by it. The approach of this PR is used in other software (and on SO).

@tlrobinson tlrobinson merged commit 2b57b2c into metabase:master Mar 21, 2017
@tlrobinson
Copy link
Contributor

@wvengen Thanks, I wasn't aware of npm_execpath, this seems much more reliable.

@wvengen wvengen deleted the feature/work-with-busybox branch March 21, 2017 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants