Add option to propagate permissions to sub collections

[tlrobinson]

Also resolves #8205

[mazameli]

Ideally I wouldn't see this toggle when dealing with a collection that doesn't have any subcollections.

[mazameli]

Here are the visual tweaks I made to the popover:

[tlrobinson]

Ideally I wouldn't see this toggle when dealing with a collection that doesn't have any subcollections.

Good point, fixed.

[mazameli]

Looks like this is ready for review from @salsakran and @kdoh. Let's merge this puppy.

[salsakran]

seems to work well from my manual testing of it

I can live with the toggle, though it does not fill me with aesthetic glee.

[kdoh]

👍 for the propagation itself.

Not sure I'm loving the overall flow of the interaction for this though. The mixture of select items that immediately close the select and set your choice and then a toggle below just feels a little messy. For lack of a better term it feels like I could use more of a moment of pause to understand what going on if I'm potentially going to affect a bunch of items I can't see here (especially since we're defaulting to on).

Also curious if there's a reason why we went for a toggle vs a checkbox here. Small distinction but to me the toggle has more of a global implication whereas a checkbox feels possibly more appropriate on a per "instance" setting like this.

[mazameli]

Cool, thanks for the feedback.

I could go either way with a checkbox vs. a toggle.

The reason that I opted for this defaulting on and it being handled by a toggle instead of a separate confirmation was:

• the unanimous user feedback was that the expected default behavior would be for the setting to propagate down
• because of that, I thought it would feel really clicky to have to confirm that expected behavior each time.

I.e., would you want to have to click this every time?

[kdoh]

I think my reaction to it was more about the context in which things are happening than the defaulting to on (which makes sense). Just feels like the put these options in a popover strategy is starting to get a little messy. Anyhoo, as reflected by the fact this is merged I think it's an overall net win.