Pay down some tech debt #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-70
to
+68
| this.setState({from: 0, query: fullQuery}); | ||
| this.setState({query: fullQuery}); |
There was a problem hiding this comment.
This should not be removed. I can see why you did this but actually there is a bug which needs to be fixed first.
Umm. If you go to this https://test.bookbrainz.org/search?q=harry+potter&from=10 , you'll notice the pagination is showing 1-20. It should be showing 11-30
I checked and saw from is missing in the props here
const props = generateProps(req, res, {
entityTypes,
from,
hideSearch: true,
nextEnabled,
resultsPerPage: size,
...searchResults
});
Then this change won't be required.
There was a problem hiding this comment.
As discussed on IRC, from is not needed in the state.
There is another issue that will be solved in a separate PR (#466 )
MonkeyDo
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There's a fair bit of tech debt lying around.
Solution
Take an initial crack at paying it down. Delete unused or duplicated code. Clean up lints. Update some doc comments. Do some style work. Introduce subtle yet horrifying bugs.
Areas of Impact
General.