Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Pagination is showing wrong range in some cases #466

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Fix: Pagination is showing wrong range in some cases #466

merged 1 commit into from
Jun 25, 2020

Conversation

prabalsingh24
Copy link
Contributor

Problem

https://test.bookbrainz.org/search?q=harry+potter&from=20
In the pagination, this should be showing 21-40 but is showing 1-20

Solution

from was not passed in the props

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.471% when pulling bc84ab3 on prabalsingh24:search-result-pagerBar into cb47939 on bookbrainz:master.

MonkeyDo
MonkeyDo approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@MonkeyDo MonkeyDo merged commit adba2b9 into metabrainz:master Jun 25, 2020
@MonkeyDo MonkeyDo mentioned this pull request Jun 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prabalsingh24 @coveralls @MonkeyDo