MBS-5641: Show language/script in relevant reports #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
commented
Jul 18, 2019
| <abbr title={l_languages(item.release.language.name)}> | ||
| {item.release.language.iso_code_3} | ||
| </abbr> | ||
| ) : lp('?', 'unset_language_script')} |
There was a problem hiding this comment.
I thought about using '[unset]' at first but it feels too long.
reosarevok
force-pushed
the
MBS-5641
branch
2 times, most recently
from
33d789d
to
32373df
Compare
|
I won't change it to match that because this is releases and for now we haven't changed release display. Maybe we should, eventually, but :) |
reosarevok
force-pushed
the
MBS-5641
branch
2 times, most recently
from
74ce81f
to
936611c
Compare
|
Changed ? to - to match other tables where we display the fact we're missing data :) |
mwiencek
approved these changes
Apr 1, 2020
Mostly follows how it's done on release search results, but I chose to show "-" rather than nothing when language or script are missing, since I feel it makes *what* is missing more understandable. Arguably could have been done so that the NoScript report only shows language and NoLanguage only script, but by showing both it also serves to show the editor whether some have already been fixed (since the language and script are loaded from the release entry and not from the saved report data).
mwiencek
added a commit
that referenced
this pull request
Apr 1, 2020
* master: Update POT files using the production database Skip exporting undefined or empty setlist to JSON Remove format_setlist filter since c7a6dc3 MBS-10360: Whitelist User-Agent header in CORS preflight requests (#1439) MBS-7465: Update the tag cloud (#1440) MBS-5641: Show language/script in relevant reports (#1157) Strip BOM in remove_invalid_characters MBS-10730: Select DISTINCT video/standalone recordings (#1443) MBS-10724: Allow sorting artist lists by begin/end area MBS-10724: Allow sorting artist/place lists by dates MBS-10724: Allow sorting artist/place lists by area MBS-10724: Allow sorting RG lists by artist MBS-9728: Allow new emojis in titles Use addColonText when possible MBS-10680: Link to WS docs from the Details tab MBS-10679: Link to JSON WS from the Details tab
yvanzo
added a commit
that referenced
this pull request
Apr 13, 2020
* beta: Update translations from Transifex Update POT files using the production database Update translations from Transifex MBS-10640: Fix donation check (#1454) MBS-10753: Order artist collections by sort name (#1159) MBS-10735: Stop highlighting CD Baby links (#1446) MBS-10747: Fix misleading open edit message (#1452) MBS-10688: Show a human readable error when attaching a dupe CDTOC (#1438) MBS-10718: Always use link orders for grouping (#1434) MBS-9894: Fix timeline month off by 1 (#1450) Bump Flow to 0.122.0 Update POT files using the production database Skip exporting undefined or empty setlist to JSON Remove format_setlist filter since c7a6dc3 MBS-10360: Whitelist User-Agent header in CORS preflight requests (#1439) MBS-7465: Update the tag cloud (#1440) MBS-5641: Show language/script in relevant reports (#1157) Strip BOM in remove_invalid_characters MBS-10730: Select DISTINCT video/standalone recordings (#1443) MBS-10724: Allow sorting artist lists by begin/end area MBS-10724: Allow sorting artist/place lists by dates MBS-10724: Allow sorting artist/place lists by area MBS-10724: Allow sorting RG lists by artist MBS-9728: Allow new emojis in titles Use addColonText when possible MBS-10680: Link to WS docs from the Details tab MBS-10679: Link to JSON WS from the Details tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.metabrainz.org/browse/MBS-5641
Mostly follows how it's done on release search results, but I chose to show "-" rather than nothing when language or script are missing, since I feel it makes what is missing more understandable.
Arguably could have been done so that the NoScript report only shows language and NoLanguage only script, but by showing both it also serves to show the editor whether some have already been fixed (since the language and script are loaded from the release entry and not from the saved report data).