Fix noisy warnings about medium: uninitialized value in numeric eq/ne #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tracklist is slightly modified without changing recordings, `recording_id` is legitimately not defined in sdiff `@changes`. Since 0 is not a possible value for recording id, this patch defaults undefined recording id to 0 for comparison between old and new ids.
Track length may legitimately be unknown when no CDTOC is attached yet.
reosarevok
approved these changes
Feb 20, 2020
mwiencek
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two not serious but very noisy warnings (in website server logs) that are often triggered when attaching a CDTOC or editing a tracklist. See commits’ message for details.
These replace the just wrong commits 88a904c and 54139c6 picked from #1377