-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MBS-2418: Show Edit URL edits in entity edit histories #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What you have works, but it might make generating the hash ref a bit easier. for my $rel (@relationships) {
my $target_type = $rel->target_type;
my $target_id = $rel->direction == 1 ? $rel->entity1_id : $rel->entity0_id;
push @{ $related_entities->{$target_type} //= [] }, $target_id;
} |
Made that change (it does require passing the URL IDs separately), added a test. |
mwiencek
approved these changes
Nov 6, 2020
mwiencek
force-pushed
the
MBS-2418
branch
2 times, most recently
from
June 6, 2021 22:06
6497639
to
4af0b9a
Compare
This should make it so that the edits show for every entity linked to a specific URL being edited.
@brainzbot, retest this please |
3 similar comments
@brainzbot, retest this please |
@brainzbot, retest this please |
@brainzbot, retest this please |
@brainzbot, retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-2418
This should make it so that the edits show for every entity linked to a specific URL being edited.
We don't look at URL-URL relationships, since they don't exist as a concept at the moment at all.
I think I don't need to check direction here, but I might be wrong?
Let's make sure this won't accidentally link a ton of stuff like last time, but the general idea seems like it just makes sense IMO.