Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MBS-11167: Normalize vk.com links to HTTPS #1743

Merged
merged 2 commits into from
Oct 14, 2020
Merged

MBS-11167: Normalize vk.com links to HTTPS #1743

merged 2 commits into from
Oct 14, 2020

Conversation

reosarevok
Copy link
Member

Implement MBS-11167

AFAICT vk.com always redirects to HTTPS now. Given there was no normalization at all before this, there's no downside I can see to standardising in the future.

MBBE-17 exists to convert preexisting VK links to HTTPS.

@reosarevok
Split socialnetwork section into its 2 components
4b9f83f
@reosarevok
MBS-11167: Normalize vk.com links to HTTPS
764499b 
AFAICT vk.com always redirects to HTTPS now.
Given there was no normalization at all before this,
there's no downside I can see to standardising in the future.

MBBE-17 exists to convert preexisting VK links to HTTPS.
@reosarevok reosarevok added the QoL Non-urgent quality of life improvements label Oct 12, 2020
yvanzo
yvanzo approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only downside is to convert 4K http for 1K https. By the way, there is no need to batch enter edits for this, there is a script to normalize to https without edit that can be run as cron.

@yvanzo
Copy link
Contributor

yvanzo commented Oct 13, 2020

Optionally you might want to override href_url in VK.pm.

@reosarevok
Copy link
Member Author

I guess if we fix them with a cron job then we have no need to do an override.

@reosarevok reosarevok merged commit 67bfedc into metabrainz:master Oct 14, 2020
@reosarevok reosarevok deleted the MBS-11167 branch October 14, 2020 04:15
@yvanzo
Copy link
Contributor

yvanzo commented Oct 14, 2020

Right, there are only 1K+ URLs, that should take a few hours. Will do only after this has been deployed in production though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwiencek mwiencek mwiencek approved these changes

@yvanzo yvanzo yvanzo approved these changes

Assignees
No one assigned
Labels
QoL Non-urgent quality of life improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reosarevok @yvanzo @mwiencek