MBS-11424: Unbreak seeding multiple RG types #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't accounting for arrays in PostParameters.js. Now we are. Tested the change manually by seeding three types and observing that they were all selected. (If it helps, you can force the ConfirmSeed page locally by removing the `$c->is_cross_origin` check, then adding it back once you're ready to submit.)
mwiencek
added
Bug
reosarevok
reviewed
Mar 8, 2021
|
https://musicbrainz.org/doc/Development/Release_Editor_Seeding#Release_group_data seems crazy out of date, we should probably update it. Will look into it. |
|
Improved the documentation for this (https://wiki.musicbrainz.org/index.php?title=Development%2FRelease_Editor_Seeding&type=revision&diff=75236&oldid=73612) and the actual test (#1961) |
reosarevok
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
LGTM. Tested via seed-love-bug (with improvements from #1961).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't accounting for arrays in PostParameters.js. Now we are.
Tested the change manually by seeding three types and observing that they were all selected. (If it helps, you can force the ConfirmSeed page locally by removing the
$c->is_cross_origincheck, then adding it back once you're ready to submit.)