MBS-12415 / MBS-12416: Limit overenthusiastic overflow-wrap #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main intention of the overflow-wrap changes was to wrap absurdly long entity names, and very long words in edit notes. By setting it everywhere, it was also affecting things like the tag button on the sidebar, or barcodes in entity lists, which does not seem useful. As such, this sets it only on <a> and on edit notes.
Wrapping here would make sense if it avoided scrolling, but it does not - it just makes the headers harder to read without adding anything remotely responsive. As such, let's stop the wrapping for now and recheck this once we have implemented the responsive header that is in the works.
reosarevok
added
the
Regression/Beta
mwiencek
approved these changes
Jun 1, 2022
|
I could reproduce them in Chrome by making the window smaller, FWIW. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-12415 / MBS-12416
The main intention of the
overflow-wrapchanges was to wrap absurdly long entity names, and very long words in edit notes. By setting it everywhere, it was also affecting things like the tag button on the sidebar, or barcodes in entity lists, which does not seem useful. As such, this sets it only on<a>and on edit notes.It also explicitly unsets it from
<a>in the header. Wrapping here would make sense if it avoided scrolling, but it does not - it just makes the headers harder to read without adding anything remotely responsive. As such, let's stop the wrapping for now and recheck this once we have implemented the responsive header that is in the works.