-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MBS-12658: Convert user ratings summary to React #2679
Conversation
b421cbe
to
cc6b7d0
Compare
@reosarevok: Has it been manually tested and how? |
It had, but this was before I added that info and I never got to re-test it yet :) I have now, so I added some info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. I reported the hard-coded RatableEntityTypeT
in comment to MBS-13003 for later on.
I tested locally by rating random entities of various types.
🚢
* master: Update POT files using the production database MBS-12769: Convert Delete relationship type page to React (#2768) MBS-12768: Convert Delete relationship attribute type page to React (#2767) MBS-12774: Convert the Delete release page to React (#2762) MBS-12659: Convert user ratings page to React (#2682) MBS-12652: Convert entity collection tab to React (#2673) MBS-12658: Convert user ratings summary to React (#2679) MBS-12779: Treat "n-bit" and "loop" as ETI if in parens (#2773) MBS-12785: Wrap things sensibly on release sidebar (#2782) MBS-12712: Improve wording for new release adding on disc ID lookup (#2754) MBS-12738 / MBS-12739: Add tests MBS-12771: Convert Change release quality page to React Make Change Quality options translatable Remove not actually useful "no results" message MBS-12998: Lower the spaghetti level of Quick links Actually set isSearch on edit search MBS-12989: Add "no vote yet" predicate for subscribed editor refining Fix inconsistent use of React$Element MBS-12739: Don't assume "single" is ETI unless it's inside parens MBS-12738: Don't assume "studio" is ETI unless it's inside parens
* beta: Update translations from Transifex Revert "MBS-13042: Increase default font size (12 -> 14px)" Update POT files using the production database Update translations from Transifex MBS-12308: Clarify the missing artist errors MBS-13042: Increase default font size (12 -> 14px) MBS-12743: Convert Delete area page to React Make $can_delete reusable MBS-12851: Hide ratings/tags stats for deleted users (#2810) MBS-12740: Convert Delete attribute page to React (#2771) MBS-13041: Fix broken Utaten favicon (#2921) Make button use the standard font size Use named variables for font size over rem MBS-12749: Convert cdtoc/attach_filter_artist to React Better formatting for InlineSubmitButton MBS-12309: Clarify /edit/subscribed also includes collection edits (#2489) Specified the OS requirements (#2915) MBS-10861: Standardize time before auto-deletion to 48 hours (#2638) Update POT files using the production database MBS-12769: Convert Delete relationship type page to React (#2768) MBS-12768: Convert Delete relationship attribute type page to React (#2767) MBS-12774: Convert the Delete release page to React (#2762) MBS-12659: Convert user ratings page to React (#2682) MBS-12652: Convert entity collection tab to React (#2673) MBS-12658: Convert user ratings summary to React (#2679) MBS-12779: Treat "n-bit" and "loop" as ETI if in parens (#2773) MBS-12785: Wrap things sensibly on release sidebar (#2782) MBS-12712: Improve wording for new release adding on disc ID lookup (#2754) MBS-12738 / MBS-12739: Add tests MBS-12771: Convert Change release quality page to React Make Change Quality options translatable Add missing space MBS-12782: Block adding CritiqueBrainz links Remove not actually useful "no results" message MBS-12998: Lower the spaghetti level of Quick links Actually set isSearch on edit search MBS-12989: Add "no vote yet" predicate for subscribed editor refining Fix inconsistent use of React$Element MBS-12739: Don't assume "single" is ETI unless it's inside parens MBS-12738: Don't assume "studio" is ETI unless it's inside parens
Implement MBS-12658
Testing
Tested manually in
/user/jesus2099/ratings
(lots of ratings) and/user/reosarevok/ratings
(no ratings at all) withfloyd
data. Also tried rating one artist only and made sure that only the artist section is shown on the page.