MBS-12659: Convert user entity type ratings page to React #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brainzbot, retest this please |
mwiencek
approved these changes
Apr 15, 2023
|
Converted to draft as it depends on another pull request. Is there any test coverage? |
|
Rebased and reopened after the other PR was merged, Github didn't update properly so I changed base and back to reset their checks. Added a bit of info about testing (which I just redid). |
yvanzo
approved these changes
Apr 19, 2023
yvanzo
added a commit
that referenced
this pull request
Apr 19, 2023
* master: Update POT files using the production database MBS-12769: Convert Delete relationship type page to React (#2768) MBS-12768: Convert Delete relationship attribute type page to React (#2767) MBS-12774: Convert the Delete release page to React (#2762) MBS-12659: Convert user ratings page to React (#2682) MBS-12652: Convert entity collection tab to React (#2673) MBS-12658: Convert user ratings summary to React (#2679) MBS-12779: Treat "n-bit" and "loop" as ETI if in parens (#2773) MBS-12785: Wrap things sensibly on release sidebar (#2782) MBS-12712: Improve wording for new release adding on disc ID lookup (#2754) MBS-12738 / MBS-12739: Add tests MBS-12771: Convert Change release quality page to React Make Change Quality options translatable Remove not actually useful "no results" message MBS-12998: Lower the spaghetti level of Quick links Actually set isSearch on edit search MBS-12989: Add "no vote yet" predicate for subscribed editor refining Fix inconsistent use of React$Element MBS-12739: Don't assume "single" is ETI unless it's inside parens MBS-12738: Don't assume "studio" is ETI unless it's inside parens
yvanzo
added a commit
that referenced
this pull request
May 2, 2023
* beta: Update translations from Transifex Revert "MBS-13042: Increase default font size (12 -> 14px)" Update POT files using the production database Update translations from Transifex MBS-12308: Clarify the missing artist errors MBS-13042: Increase default font size (12 -> 14px) MBS-12743: Convert Delete area page to React Make $can_delete reusable MBS-12851: Hide ratings/tags stats for deleted users (#2810) MBS-12740: Convert Delete attribute page to React (#2771) MBS-13041: Fix broken Utaten favicon (#2921) Make button use the standard font size Use named variables for font size over rem MBS-12749: Convert cdtoc/attach_filter_artist to React Better formatting for InlineSubmitButton MBS-12309: Clarify /edit/subscribed also includes collection edits (#2489) Specified the OS requirements (#2915) MBS-10861: Standardize time before auto-deletion to 48 hours (#2638) Update POT files using the production database MBS-12769: Convert Delete relationship type page to React (#2768) MBS-12768: Convert Delete relationship attribute type page to React (#2767) MBS-12774: Convert the Delete release page to React (#2762) MBS-12659: Convert user ratings page to React (#2682) MBS-12652: Convert entity collection tab to React (#2673) MBS-12658: Convert user ratings summary to React (#2679) MBS-12779: Treat "n-bit" and "loop" as ETI if in parens (#2773) MBS-12785: Wrap things sensibly on release sidebar (#2782) MBS-12712: Improve wording for new release adding on disc ID lookup (#2754) MBS-12738 / MBS-12739: Add tests MBS-12771: Convert Change release quality page to React Make Change Quality options translatable Add missing space MBS-12782: Block adding CritiqueBrainz links Remove not actually useful "no results" message MBS-12998: Lower the spaghetti level of Quick links Actually set isSearch on edit search MBS-12989: Add "no vote yet" predicate for subscribed editor refining Fix inconsistent use of React$Element MBS-12739: Don't assume "single" is ETI unless it's inside parens MBS-12738: Don't assume "studio" is ETI unless it's inside parens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-12659
Testing
Tested manually in
/user/jesus2099/ratings/artist?page=1(lots of ratings in several pages),/user/jesus2099/ratings/event?page=1(a few ratings, one page), and/user/reosarevok/ratings/artist?page=1(no ratings at all), withfloyddata.