MBS-12801: Warn users about "Disc n" titles on release merge #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
reviewed
Nov 3, 2023
This is a basic warning, which is probably enough. We could also disable submission unless they confirm, by erroring at the Perl level, but this is less intrusive and hopefully does the trick still, since it appears just below the name row as soon as the user enters the triggering name.
mwiencek
approved these changes
Dec 5, 2023
yvanzo
added a commit
that referenced
this pull request
Dec 12, 2023
* master: Update POT files using the production database Amend PR #3083: Fix ESLint max-len warning Amend e56e14a: Fix ESLint warning Add context to ’Edit’ messages Disambiguate tags in message context Add missing vote context Add numeration for cover art in message context Fix numeration in cover art message context Add missing context for cover art headers Uniformize ‘Merge’/‘Into’ message context Add context to messages about email address Add message context to all edit statuses Update ‘Update’ message context Use a single context for interactive UI elements Amend b8f9b01: Uniformize/simplify context message Amend 36544df: Uniformize/simplify context message Add "edit type" context to all edit types Add context to "open edits", "edit types", "edit note(s)" Use "edit type" over "edit name" for context Standardize strings outside of root/*/ and add context Standardize /work strings and add context Standardize /url strings and add context Standardize /taglookup strings and add context Standardize /tag strings and add context Standardize /statistics strings and add context Standardize /static strings and add context Standardize /series strings and add context Standardize /search strings and add context Standardize /report strings and add context Standardize /release_group strings and add context Standardize /release strings and add context Standardize /relationship strings and add context Standardize /recording strings and add context Standardize /place strings and add context Standardize /otherlookup strings and add context Standardize /oauth2 strings and add context Standardize /medium strings and add context Standardize /mbid strings and add context Standardize /main strings and add context Standardize /layout strings and add context Standardize /label strings and add context Standardize /instrument strings and add context Standardize /genre strings and add context Standardize /forms strings and add context Standardize /event strings and add context Standardize /entity strings and add context Standardize /doc strings and add context Standardize /components strings and add context Standardize /collection strings and add context Standardize /cdtoc strings and add context Standardize /cdstub strings and add context Standardize /artist_credit strings and add context Standardize /artist strings and add context Standardize /area strings and add context Standardize /edit strings and add context Standardize admin strings and add context Add utf8 to test using Unicode apostrophe. Standardize artist credit strings and add context Standardize user/account strings and add context Standardize user action messages and add context Standardize user type messages and add context Standardize "Add/edit/remove alias" messages and add context Standardize "Add/edit annotation" messages and add context Standardize "Edit entity" messages and add context Standardize "Remove entity" messages and add context Standardize cover art related strings Standardize menu headings Standardize "Add entity" messages and add context Add missing spaces before 'rw' Support CODE defaults in saves_preferences Simplify the preferences form display MBS-12560: Stop using track ID for recording ID URL (#2616) MBS-13139: Stay on the same page when going to MB.org (#2972) Apply changes from ae3f721 to commaList MBS-13365: Flatten commaOnlyList result MBS-13378: Add preference for note emails on abstain votes MBS-13377: Actually use email_on_vote preference MBS-13364: Always send note emails to edit author webpack/exec.mjs: log stdout, stderr if there's an error Add webpack/exec to exec webpack/exec.mjs Document React state management (#2815) Avoid using multiple with in Edit:: files (#2752) MBS-13397: Support video pages for jazzmusic/metalmusic/progarchives (#3118) Avoid using multiple with in Data:: files Use React$FragmentType rather than typeof React.Fragment (#3117) Fix quick links key warning (#3049) Use IDs rather than names for link types MBS-12324: Don't flag characters in ArtistsThatMayBePersons report Drop "catalogued" from ArtistsThatMayBePersons MBS-12323: Consider more person-only rels for ArtistsThatMayBePersons MBS-12318: Consider subgroup rels for ArtistsThatMayBe reports MBS-12725: Add "Refine this search" link on Votes by [user] page (#2756) MBS-12801: Warn users about "Disc n" titles on release merge (#2788) MBS-11556: Standardise / clean up YouTube Music URLs (#2494) Preserve some messages after commit 05960f8 Move test to save build time (3× `git ls-files`) Drop unused and useless lp_admin Clean up before expanding admin-only messages MBS-13117: Drop message localization in admin pages Add tests for compareRelationships Declare phony targets in po/Makefile lint: Uniformize indent to tab in Makefiles Test in CI that admin pages avoid localization Use exp.l_admin in admin-only pages Use l_admin as appropriate in non-admin pages Add ((t)exp.)l[np]_admin for admin messages Skip extracting messages from non-module files Exclude admin files from source message extraction Follow Perl::Critic::Policy::Modules::RequireEndWithOne Follow Perl::Critic::Policy::Modules::ProhibitConditionalUseStatements Follow Perl::Critic::Policy::Modules::ProhibitAutomaticExportation Follow Perl::Critic::Policy::Modules::ProhibitModuleShebang Don't apply both Role::SelectAll and Role::OptionsTree Avoid using multiple with in Entity:: files (#2704) Follow Perl::Critic::Policy::ValuesAndExpressions::ProhibitConstantPragma Remove mostly unused Server::Release Follow Perl::Critic::Policy::ValuesAndExpressions::ProhibitEscapedCharacters Consistently use named constants for HTTP responses Remove duplicate use strict Follow Perl::Critic::Policy::ValuesAndExpressions::ProhibitQuotesAsQuotelikeOperatorDelimiters Follow Perl::Critic::Policy::ValuesAndExpressions::RequireQuotedHeredocTerminator Add Perl::Critic::Policy::ValuesAndExpressions::RequireUpperCaseHeredocTerminator Follow Perl::Critic::Policy::ValuesAndExpressions::ProhibitNullStatements Follow Perl::Critic::Policy::ValuesAndExpressions::ProhibitEmptyCommas Add a way to regenerate cpanfile.perl5.30.snapshot Fix focal image tag in Dockerfile.perl5.30.tests Bump musicbrainz-tests image versions Add Perl::Critic::Policy::CodeLayout::ProhibitIfIfSameLine Follow Perl::Critic::Policy::CodeLayout::RequireFinalSemicolon Follow Perl::Critic::Policy::CodeLayout::RequireTrailingCommaAtNewline Move EOF heredocs outside parens, indent it Add Perl::Critic::Policy::CodeLayout::ProhibitQuotedWordLists Also block leading tabs with PerlCritic Document running Selenium tests that use search Fix ChromeDriver link Make _hash_to_row methods more consistent (#2729) Add missing metalmusicarchives favicon class MBS-13388: Handle vk.gy links MBS-13368: Properly compare series relationships if series is target MBS-12122: Add URL as edit search option MBS-12815: Support immutable URL edit search predicate Amend a57b065: Fix returning error 404 page Split deleting own account off to its own path MBS-13055: Search instrument attributes by alias MBS-13340: Case-insensitive instrument attribute search Replace global.js with globalThis Call export*TypeInfo in tests/relationship-editor.js Output Flow types in typeInfo.js Entity::Role::OptionsTree: Output description as non-null LinkTypeAttrTypeT (Flow): Add `typeID` property LinkTypeT (Flow): `examples` can be null Add Perl::Critic::Policy::ClassHierarchies::ProhibitOneArgBless Follow Perl::Critic::Policy::ClassHierarchies::ProhibitExplicitISA Add Perl::Critic::Policy::ClassHierarchies::ProhibitAutoloading
reosarevok
added a commit
that referenced
this pull request
Dec 18, 2023
* beta: Translated using Weblate (Italian) Translated using Weblate (Spanish) Update translation files Add missing lp import Update POT files using the production database Amend 8c57af5: Avoid translating more messages (#3125) Translated using Weblate (French) Translated using Weblate (Spanish) Update translation files Translated using Weblate (Lithuanian) Amend 9d257b7/3f0e317: Align with work edit form Amend ef90abd: Change letter-case in all occurrences Amend ef90abd: Change title in old template too Amend 926cea5: Change report’s title in index too Update POT files using the production database Translated using Weblate (Spanish) Translated using Weblate (Lithuanian) Translated using Weblate (French) Update translation files Translated using Weblate (Spanish) Add context to "Edit information" Remind about updating translations when releasing MBS-13404: Avoid duplicating feat. artists (#3123) Improve wording for a recently modified string Unify text about application’s callback URI Unify the text for possibly duplicate events Fix typo reported by Salo.Rock Add missing full stop to a recently udpated string Drop colon from recently added/modified messages Fix ending punctuation and typographic apostrophes Fix typo: Remove trailing space Unify the text for empty annotation Update POT files using the production database Uppercase MusicBrainz Database as a product name Lowercase and add context to "Delete Account" Lowercase forgotten CD Stub Also add 'edit status' context to JS list of statuses MBS-13117 (II): Make more admin strings untranslatable (#3120) Lowercase some more forgotten strings (#3121) Specify "plural" for series in preferences form Specify "data" quality in edit search Lowercase left behind "Attach Disc ID" Update translation files Update POT files using the production database Translated using Weblate (German) Update translation files Update POT files using the production database Amend PR #3083: Fix ESLint max-len warning Amend e56e14a: Fix ESLint warning Add context to ’Edit’ messages Disambiguate tags in message context Add missing vote context Add numeration for cover art in message context Fix numeration in cover art message context Add missing context for cover art headers Uniformize ‘Merge’/‘Into’ message context Add context to messages about email address Add message context to all edit statuses Update ‘Update’ message context Use a single context for interactive UI elements Amend b8f9b01: Uniformize/simplify context message Amend 36544df: Uniformize/simplify context message Add "edit type" context to all edit types Add context to "open edits", "edit types", "edit note(s)" Use "edit type" over "edit name" for context Standardize strings outside of root/*/ and add context Standardize /work strings and add context Standardize /url strings and add context Standardize /taglookup strings and add context Standardize /tag strings and add context Standardize /statistics strings and add context Standardize /static strings and add context Standardize /series strings and add context Standardize /search strings and add context Standardize /report strings and add context Standardize /release_group strings and add context Standardize /release strings and add context Standardize /relationship strings and add context Standardize /recording strings and add context Standardize /place strings and add context Standardize /otherlookup strings and add context Standardize /oauth2 strings and add context Standardize /medium strings and add context Standardize /mbid strings and add context Standardize /main strings and add context Standardize /layout strings and add context Standardize /label strings and add context Standardize /instrument strings and add context Standardize /genre strings and add context Standardize /forms strings and add context Standardize /event strings and add context Standardize /entity strings and add context Standardize /doc strings and add context Standardize /components strings and add context Standardize /collection strings and add context Standardize /cdtoc strings and add context Standardize /cdstub strings and add context Standardize /artist_credit strings and add context Standardize /artist strings and add context Standardize /area strings and add context Standardize /edit strings and add context Standardize admin strings and add context Add utf8 to test using Unicode apostrophe. Standardize artist credit strings and add context Standardize user/account strings and add context Standardize user action messages and add context Standardize user type messages and add context Standardize "Add/edit/remove alias" messages and add context Standardize "Add/edit annotation" messages and add context Standardize "Edit entity" messages and add context Standardize "Remove entity" messages and add context Standardize cover art related strings Standardize menu headings Standardize "Add entity" messages and add context Translated using Weblate (German) Translated using Weblate (German) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (Portuguese) Translated using Weblate (Lithuanian) Add missing spaces before 'rw' Support CODE defaults in saves_preferences Simplify the preferences form display MBS-12560: Stop using track ID for recording ID URL (#2616) MBS-13139: Stay on the same page when going to MB.org (#2972) Apply changes from ae3f721 to commaList MBS-13365: Flatten commaOnlyList result MBS-13378: Add preference for note emails on abstain votes MBS-13377: Actually use email_on_vote preference MBS-13364: Always send note emails to edit author webpack/exec.mjs: log stdout, stderr if there's an error Add webpack/exec to exec webpack/exec.mjs Document React state management (#2815) Avoid using multiple with in Edit:: files (#2752) MBS-13397: Support video pages for jazzmusic/metalmusic/progarchives (#3118) Avoid using multiple with in Data:: files Use React$FragmentType rather than typeof React.Fragment (#3117) Fix quick links key warning (#3049) Use IDs rather than names for link types MBS-12324: Don't flag characters in ArtistsThatMayBePersons report Drop "catalogued" from ArtistsThatMayBePersons MBS-12323: Consider more person-only rels for ArtistsThatMayBePersons MBS-12318: Consider subgroup rels for ArtistsThatMayBe reports MBS-12725: Add "Refine this search" link on Votes by [user] page (#2756) MBS-12801: Warn users about "Disc n" titles on release merge (#2788) MBS-11556: Standardise / clean up YouTube Music URLs (#2494) Preserve some messages after commit 05960f8 MBS-13393: Reduce the relationship data stored in sessionStorage Remove undefined properties from external links editor state MBS-13392: Restore external links editor submission upon form reload Move test to save build time (3× `git ls-files`) Drop unused and useless lp_admin Clean up before expanding admin-only messages MBS-13117: Drop message localization in admin pages Add tests for compareRelationships Declare phony targets in po/Makefile lint: Uniformize indent to tab in Makefiles Test in CI that admin pages avoid localization Use exp.l_admin in admin-only pages Use l_admin as appropriate in non-admin pages Add ((t)exp.)l[np]_admin for admin messages Skip extracting messages from non-module files Exclude admin files from source message extraction Follow Perl::Critic::Policy::Modules::RequireEndWithOne Follow Perl::Critic::Policy::Modules::ProhibitConditionalUseStatements Follow Perl::Critic::Policy::Modules::ProhibitAutomaticExportation Follow Perl::Critic::Policy::Modules::ProhibitModuleShebang Don't apply both Role::SelectAll and Role::OptionsTree Avoid using multiple with in Entity:: files (#2704) Follow Perl::Critic::Policy::ValuesAndExpressions::ProhibitConstantPragma Remove mostly unused Server::Release Follow Perl::Critic::Policy::ValuesAndExpressions::ProhibitEscapedCharacters Consistently use named constants for HTTP responses Remove duplicate use strict Follow Perl::Critic::Policy::ValuesAndExpressions::ProhibitQuotesAsQuotelikeOperatorDelimiters Follow Perl::Critic::Policy::ValuesAndExpressions::RequireQuotedHeredocTerminator Add Perl::Critic::Policy::ValuesAndExpressions::RequireUpperCaseHeredocTerminator Follow Perl::Critic::Policy::ValuesAndExpressions::ProhibitNullStatements Follow Perl::Critic::Policy::ValuesAndExpressions::ProhibitEmptyCommas Add a way to regenerate cpanfile.perl5.30.snapshot Fix focal image tag in Dockerfile.perl5.30.tests Bump musicbrainz-tests image versions Add Perl::Critic::Policy::CodeLayout::ProhibitIfIfSameLine Follow Perl::Critic::Policy::CodeLayout::RequireFinalSemicolon Follow Perl::Critic::Policy::CodeLayout::RequireTrailingCommaAtNewline Move EOF heredocs outside parens, indent it Add Perl::Critic::Policy::CodeLayout::ProhibitQuotedWordLists Also block leading tabs with PerlCritic Document running Selenium tests that use search Fix ChromeDriver link Make _hash_to_row methods more consistent (#2729) Make all form/field types read-only Update mutate-cow to v5 Add missing metalmusicarchives favicon class MBS-13388: Handle vk.gy links MBS-13368: Properly compare series relationships if series is target MBS-12122: Add URL as edit search option MBS-12815: Support immutable URL edit search predicate Amend a57b065: Fix returning error 404 page Split deleting own account off to its own path MBS-13055: Search instrument attributes by alias MBS-13340: Case-insensitive instrument attribute search Replace global.js with globalThis Call export*TypeInfo in tests/relationship-editor.js Output Flow types in typeInfo.js Entity::Role::OptionsTree: Output description as non-null LinkTypeAttrTypeT (Flow): Add `typeID` property LinkTypeT (Flow): `examples` can be null Add Perl::Critic::Policy::ClassHierarchies::ProhibitOneArgBless Follow Perl::Critic::Policy::ClassHierarchies::ProhibitExplicitISA Add Perl::Critic::Policy::ClassHierarchies::ProhibitAutoloading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-12801
Problem
MBS-12034 made it mandatory to provide a confirmation when adding a "Disc 1" style medium name when editing a release. I did not remember, when implementing it, that there is a second place where you can set medium names: the release merge page. Right now, nothing blocks adding those from that page nor warns the user it might be a bad idea.
Solution
I just implemented a basic warning, which is probably enough. We could also disable submission unless they confirm, by erroring at the Perl level, but this is less intrusive and hopefully does the trick still, since it appears just below the name row as soon as the user enters the triggering name.
Testing
Tested manually when merging two random releases, since the testing is only dependent on the entered medium name.