-
-
Notifications
You must be signed in to change notification settings - Fork 279
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
This is a basic warning, which is probably enough. We could also disable submission unless they confirm, by erroring at the Perl level, but this is less intrusive and hopefully does the trick still, since it appears just below the name row as soon as the user enters the triggering name.
- Loading branch information
1 parent
ae2c37b
commit 2f5511a
Showing
5 changed files
with
94 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/* | ||
* @flow strict | ||
* Copyright (C) 2023 MetaBrainz Foundation | ||
* | ||
* This file is part of MusicBrainz, the open internet music database, | ||
* and is licensed under the GPL version 2, or (at your option) any | ||
* later version: http://www.gnu.org/licenses/gpl-2.0.txt | ||
*/ | ||
|
||
export default function isUselessMediumTitle(title: string): boolean { | ||
return /^(Cassette|CD|Dis[ck]|DVD|SACD|Vinyl)\s*\d+/i.test(title); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
root/static/scripts/tests/edit/utility/isUselessMediumTitle.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/* | ||
* @flow strict | ||
* Copyright (C) 2023 MetaBrainz Foundation | ||
* | ||
* This file is part of MusicBrainz, the open internet music database, | ||
* and is licensed under the GPL version 2, or (at your option) any | ||
* later version: http://www.gnu.org/licenses/gpl-2.0.txt | ||
*/ | ||
|
||
import test from 'tape'; | ||
|
||
import isUselessMediumTitle | ||
from '../../../edit/utility/isUselessMediumTitle.js'; | ||
|
||
test('isUselessMediumTitle', function (t) { | ||
t.plan(3); | ||
|
||
t.ok( | ||
!isUselessMediumTitle('The Happy Disc'), | ||
'A normal title is not useless', | ||
); | ||
|
||
t.ok( | ||
isUselessMediumTitle('DVD 42'), | ||
'A "format plus number" title is useless', | ||
); | ||
|
||
t.ok( | ||
isUselessMediumTitle('Disk1'), | ||
'A "format plus number" title is still useless if not space-separated', | ||
); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters