MBS-4902: Add more social networking sites to sidebar #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| with 'MusicBrainz::Server::Entity::URL::Sidebar'; | ||
|
|
||
| sub sidebar_name { | ||
| my $self = shift; |
There was a problem hiding this comment.
for future reference, since in this case you aren't actually using $self, you don't need this line at all; it's fine for it to be there though.
|
🚢 ! |
|
Though I'd probably rename the ticket to be more concrete/specific. (Unless you wish to add more sites to it, of course.) |
|
🚢 it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ticket title is vague but the text asks only for G+ - we had autoselect and cleanup in place so this is literally just making it appear in the sidebar. Tested manually on sandbox.