Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document option to enable/disable guessing track no. / title from fil… #105

Merged

Conversation

phw
Copy link
Member

@phw phw commented May 3, 2021

…ename

Summary

This is a…

  • Correction
  • Addition
  • Restructuring
  • Minor / simple change (like a typo)
  • Other

Reason for the Change

Documentation for metabrainz/picard#1798

Additional Action Required

Need to update the screenshot

@phw phw requested a review from rdswift May 3, 2021 12:32
@phw phw added the documentation Improvements or additions to documentation label May 3, 2021
Copy link
Collaborator

@rdswift rdswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

What do you think about having a TODO: list for the 2.7 release (perhaps on PR #104) to keep track of what screen shots also need to be updated? Either that or we should update them along with the text changes.

@phw phw merged commit 1cbc838 into metabrainz:next_version_2.7 May 3, 2021
@phw phw deleted the option-guess-tracknumber-title branch May 3, 2021 16:24
@phw
Copy link
Member Author

phw commented May 3, 2021

What do you think about having a TODO: list for the 2.7 release (perhaps on PR #104) to keep track of what screen shots also need to be updated? Either that or we should update them along with the text changes.

I started that on https://github.com/rdswift/picard-docs/pull/104 already, actually with exactly this in mind. I think updating screenshots is better done later, because we don't know what else we'll change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
2 participants