PICARD-2271: Add Options page to allow removing unused settings from INI file. #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move `import` to top of module. - Refactor to remove `_add_options_from_page()` method. - Use standard QSettings methods to get `file_options` set. - Add comment explaining the calculation for `row_height`.
34 tasks
zas
requested changes
Sep 2, 2021
- Use more descriptive variable name `option_name`. - Set value as PlainText. - Store option keys as `UserRole` data. - Remove redundant (default) options to `QMessageBox`. - Use `repr()` to return option values.
zas
requested changes
Sep 2, 2021
zas
requested changes
Sep 2, 2021
phw
reviewed
Sep 3, 2021
Me too. It's amazing all the stuff that accumulates in your test configuration file during development. 😜
Perfect! I'll make the change right away. |
phw
previously approved these changes
Sep 3, 2021
zas
requested changes
Sep 3, 2021
rdswift
force-pushed
the
clean_unused_config_options
branch
from
23b141d
to
d53ffa4
Compare
zas
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Over the course of trying out plugins and such, the configuration INI file can become bloated with orphaned settings.
Solution
Provide a new Options page (called "Maintenance") that lists all orphaned settings found in the INI file, and allows the user to mark the settings for deletion.
This allows you to remove unused option settings from the configuration file.
Settings that are found in the configuration file that do not appear on any option settings page will be listed. If the configuration file does not contain any unused option settings, then the list will be empty.
Note that unused option settings could come from plugins that have been uninstalled, so care must be taken to not remove settings that you may want to use later when the plugin is reinstalled. Options belonging to plugins that are installed, including those that are currently disabled, will not be listed for possible removal.
To remove one or more settings, select the settings to remove by checking the box next to the setting, and then enable the removal by checking the
Remove selected optionsbox. When you chooseMake It So!to save your option settings, the selected items will be removed.Action
If this change is accepted, the documentation will need to be updated.