Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadatabox cleanup #2476

Merged
merged 29 commits into from
May 19, 2024
Merged

Metadatabox cleanup #2476

merged 29 commits into from
May 19, 2024

Commits on May 17, 2024

  1. MetadataBox: use self as parent of QtGui.QAction actions

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6c83732 View commit details
    Browse the repository at this point in the history

  2. lookup_tags() -> _lookup_tags()

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e9f90e6 View commit details
    Browse the repository at this point in the history

  3. get_file_lookup() -> _get_file_lookup()

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    bb8091c View commit details
    Browse the repository at this point in the history

  4. open_link() -> _open_link()

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    74eb110 View commit details
    Browse the repository at this point in the history

  5. copy/paste_value() -> _copy/_paste_value()

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c945991 View commit details
    Browse the repository at this point in the history

  6. update_clipboard() -> _update_clipboard()

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    385bd3c View commit details
    Browse the repository at this point in the history

  7. edit_tag() -> _edit_tag() 

    # Conflicts:
#	picard/ui/metadatabox.py
    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    903d3dc View commit details
    Browse the repository at this point in the history

  8. edit_selected_tag() -> _edit_selected_tag()

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    a106bc9 View commit details
    Browse the repository at this point in the history

  9. toggle_changes_first() -> _toggle_changes_first()

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    02d191d View commit details
    Browse the repository at this point in the history

  10. set_tag_values() -> _set_tag_values()

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    d1a9f0d View commit details
    Browse the repository at this point in the history

  11. remove_tag() -> _remove_tag()

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    901acc9 View commit details
    Browse the repository at this point in the history

  12. tag_is_(removable|editable)() -> _tag_is_(removable|editable)()

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    8e53ebb View commit details
    Browse the repository at this point in the history

  13. remove_selected_tags(): no need to check if tag is removable, as the … 

    …list is filtered already
    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    0396808 View commit details
    Browse the repository at this point in the history

  14. selected_tags() -> _selected_tags()

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    888df23 View commit details
    Browse the repository at this point in the history

  15. _selected_tags(): make it a generator

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    7a620f0 View commit details
    Browse the repository at this point in the history

  16. set_item_value() -> _set_item_value()

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    953bdbc View commit details
    Browse the repository at this point in the history

  17. Drop _lookup_tags() in favor of new _lookup_tag(tag) 

    - define methods to use as strings and use getattr()
    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    94ff51e View commit details
    Browse the repository at this point in the history

  18. Test if methods listed in MetadataBox.LOOKUP_TAGS are valid FileLooku… 

    …p methods
    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6a1d568 View commit details
    Browse the repository at this point in the history

  19. Use named columns instead of numerical values

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    1d06036 View commit details
    Browse the repository at this point in the history

  20. name -> tag (as we iterate among tags)

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6157063 View commit details
    Browse the repository at this point in the history

  21. Use if/continue instead of filter(lambda...), more readable

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6ed7802 View commit details
    Browse the repository at this point in the history

  22. Use self.tag_diff after it was set to result 

    It will make it easier to move code
    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    f82c5ac View commit details
    Browse the repository at this point in the history

  23. Minor code redundancy reduction

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    43a1103 View commit details
    Browse the repository at this point in the history

  24. Consistency: we use tag instead of name everywhere else in the file

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    4e1ff55 View commit details
    Browse the repository at this point in the history

  25. _update_items(): regroup code per column 

    - alignment never changes, move it outside the loop
- set new_item flags once at object creation
- it makes the code a bit easier to read imho
    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    be261bb View commit details
    Browse the repository at this point in the history

  26. Use a namedtuple for display values, with fields text and is_grouped 

    - it makes things a bit clearer
- it will be easier to add new fields
    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    138996d View commit details
    Browse the repository at this point in the history

  27. different -> is_grouped

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    a095e31 View commit details
    Browse the repository at this point in the history

  28. Add two helper functions to toggle between grouped and normal values

    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    14db96d View commit details
    Browse the repository at this point in the history

  29. Variables orig_tags and new_tags aren't needed, drop keys() as it's t… 

    …he default for dicts
    @zas
    zas committed May 17, 2024
    Configuration menu
    Copy the full SHA
    72c7c60 View commit details
    Browse the repository at this point in the history