Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadatabox cleanup #2476

Merged
merged 29 commits into from
May 19, 2024
Merged

Metadatabox cleanup #2476

merged 29 commits into from
May 19, 2024

Conversation

zas
Copy link
Collaborator

@zas zas commented May 17, 2024

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

Solution

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

@zas zas requested a review from phw May 17, 2024 13:03
- define methods to use as strings and use getattr()
@zas
Copy link
Collaborator Author

zas commented May 17, 2024

28d2b17 is a new feature, it will go in another PR if reviews are positive, just a PoC.

EDIT: move to #2478 (based on this branch though)

@zas zas marked this pull request as ready for review May 18, 2024 09:20
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is working great. Having this merged will also simplify reviewing #2478 (once rebased)

@zas zas merged commit 38304af into metabrainz:master May 19, 2024
45 checks passed
@zas zas deleted the metadatabox_cleanup branch May 19, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants