Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PICARD-2913: Let user configure syntax highlighting colors #2498

Merged
merged 1 commit into from
May 27, 2024

Conversation

zas
Copy link
Collaborator

@zas zas commented May 26, 2024

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

Script syntax highlighting colors are hardcoded.

Solution

Let the user configure them in Options > Interface > Colors

image

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

@zas zas requested review from phw and rdswift May 26, 2024 17:27
@zas zas force-pushed the config_syntax_colors branch 2 times, most recently from e7c6ae2 to 4f74934 Compare May 26, 2024 17:53
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

picard/ui/widgets/scripttextedit.py Show resolved Hide resolved
@zas zas merged commit cdbf643 into metabrainz:master May 27, 2024
45 checks passed
@zas zas deleted the config_syntax_colors branch May 27, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants