Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI tests failing for windows with nodejs #362

Closed
pkspyder007 opened this issue Jan 4, 2023 · 1 comment
Closed

CI tests failing for windows with nodejs #362

pkspyder007 opened this issue Jan 4, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@pkspyder007
Copy link
Contributor

🐛 Bug Report

If we add nodejs in win-test workflow for CI testing the build fails

Expected Behavior

Pass all tests

Current Behavior

Build/Tests fail

Steps to Reproduce

Update win-test.yaml to include nodejs in build step

link to CI logs https://github.com/pkspyder007/metacall-core/actions/runs/3840849894/jobs/6540391480
@pkspyder007 pkspyder007 added the bug Something isn't working label Jan 4, 2023
@viferga
Copy link
Member

viferga commented Jan 5, 2023

It is failing due to your include change:

2023-01-04T19:10:39.3998775Z D:\a\metacall-core\metacall-core\source\loaders\node_loader\source\node_loader_port.cpp(34,10): fatal error C1083: Cannot open include file: 'cstdlib.h': No such file or directory [D:\a\metacall-core\metacall-core\build\source\loaders\node_loader\node_loader.vcxproj]

@viferga viferga closed this as completed Jan 5, 2023
@pkspyder007 pkspyder007 mentioned this issue Jan 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@viferga @pkspyder007