Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] use SysctlRaw to findProcessName to reduce mem allocs and copy #1392

Closed
2 tasks done
ruokeqx opened this issue Jul 16, 2024 · 0 comments
Closed
2 tasks done
Labels
enhancement New feature or request

Comments

@ruokeqx
Copy link

ruokeqx commented Jul 16, 2024

Verify steps

Description

syscall.Sysctl make a slice byte buf and convert to string when return.
func findProcessName convert string to slice byte again.
This malloc and copy mem twice unnecessarily.
net.inet.tcp.pcblist_n usually not a small piece of mem, and copy twice would cause mem waste.
Use golang.org/x/sys/unix.SysctlRaw instead.

Possible Solution

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant