Call LineRecorder receiver's closeStream() (#433) #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under some circumstances (e.g. if the JVM is not stopped after processing) the streams of receivers connected to LineRecorder are not closed, resulting in empty or missing output data. By switching from "implements ObjectPipe" to "extends DefaultObjectPipe" in LineRecorde the "DefaultSender" is used which implements the Sender interface. This ensures the proper closing of streams. - complement test
|
@blackwinter I do like this approach much more than #434. What do you think? |
6 tasks
fsteeg
approved these changes
Jan 3, 2022
blackwinter
reviewed
Jan 10, 2022
| */ | ||
| protected ObjectReceiver<String> getReceiver() { | ||
| return receiver; | ||
| public void onResetStream() { |
There was a problem hiding this comment.
Minor: I think this should be protected.
dr0i
added a commit
that referenced
this pull request
Jan 11, 2022
Some "@OverRide" methods used the "public" modifier, which is not necessary. Looking at the base classes of these classes a "protected" modifier was used, so "protected" seems to be intentionally.
This was referenced Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some circumstances (e.g. if the JVM is not stopped after processing)
the streams of receivers connected to LineRecorder are not closed, resulting
in empty or missing output data.
By switching from "implements ObjectPipe" to "extends DefaultObjectPipe" the "DefaultSender"
is used which implements the Sender interface. This ensures the proper closing of streams.
See #433.