Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for multi column lookup to put_filemap() #265

Closed
TobiasNx opened this issue Oct 13, 2022 · 16 comments · Fixed by #266
Closed

Add options for multi column lookup to put_filemap() #265

TobiasNx opened this issue Oct 13, 2022 · 16 comments · Fixed by #266
Assignees
Labels
enhancement New feature or request

Comments

@TobiasNx
Copy link
Collaborator

TobiasNx commented Oct 13, 2022

@blackwinter Introduced multi column lookup to metafacture morph. to use this in fix we need some additional options with put_filemap()

metafacture/metafacture-core#471

@TobiasNx TobiasNx added the enhancement New feature or request label Oct 13, 2022
@blackwinter
Copy link
Member

This hasn't even been merged yet, much less released.

(Also, it's not specific to Metamorph.)

@blackwinter
Copy link
Member

The feature has been merged, now we have to wait for a (pre-)release before we can continue here.

@dr0i
Copy link
Member

dr0i commented Oct 17, 2022

Do I understand this correctly - you need a pre release of metafacture-core to enable this in Metafix? Would a sonatype snaphsot be enough?

@blackwinter
Copy link
Member

It depends on how urgent this is for @TobiasNx. IMO, we should try not to depend on snapshot releases.

@TobiasNx
Copy link
Collaborator Author

We need this for : hbz/lobid-resources#1473 which blocks hbz/lobid-resources#1471

@dr0i
Copy link
Member

dr0i commented Oct 20, 2022

@blackwinter: what shall we do ? As I would not want to go through the hassle of a maven publication:
are you ok with working on a feature branch (which lobid-resources could use then) or would you rather want to consume a github package (which we could use a kind of "pre release" as @fsteeg suggested)?

@blackwinter
Copy link
Member

A GitHub package would be sufficient.

@blackwinter blackwinter assigned dr0i and unassigned blackwinter Oct 20, 2022
@blackwinter
Copy link
Member

are you ok with working on a feature branch

We need a published artifact of metafacture-core to consume in metafacture-fix. A feature branch wouldn't help.

@dr0i
Copy link
Member

dr0i commented Oct 20, 2022

Artifacts should be published to https://github.com/orgs/metafacture/packages?repo_name=metafacture-core in a few minutes.

@blackwinter
Copy link
Member

A GitHub package would be sufficient.

Now that the packages are up, maybe I spoke too soon. We can't (rather, shouldn't) depend on unstable versions.

But as you said that a feature branch was acceptable for lobid-resources, you can work off of the WIP PR #266, right?

@dr0i
Copy link
Member

dr0i commented Oct 21, 2022

Yes, working with a fetaure branch is ok for me.

@blackwinter blackwinter assigned TobiasNx and unassigned dr0i Nov 14, 2022
@dr0i
Copy link
Member

dr0i commented Nov 15, 2022

@TobiasNx can you do the functional review using the branch 265-filemapOptions?

@TobiasNx
Copy link
Collaborator Author

I try to set an integration test for this. But it seems not to work yet. @blackwinter could you have a look?

@TobiasNx TobiasNx assigned blackwinter and unassigned TobiasNx Nov 17, 2022
@blackwinter
Copy link
Member

Look where? What's not working?

TobiasNx added a commit that referenced this issue Nov 17, 2022
@TobiasNx
Copy link
Collaborator Author

@blackwinter : I didn't push. Should be pushed now. Sorry.

TobiasNx added a commit that referenced this issue Nov 18, 2022
@TobiasNx
Copy link
Collaborator Author

Thanks

TobiasNx added a commit that referenced this issue Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants