-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options for multi column lookup to put_filemap()
#265
Comments
This hasn't even been merged yet, much less released. (Also, it's not specific to Metamorph.) |
The feature has been merged, now we have to wait for a (pre-)release before we can continue here. |
Do I understand this correctly - you need a pre release of metafacture-core to enable this in Metafix? Would a sonatype snaphsot be enough? |
It depends on how urgent this is for @TobiasNx. IMO, we should try not to depend on snapshot releases. |
We need this for : hbz/lobid-resources#1473 which blocks hbz/lobid-resources#1471 |
@blackwinter: what shall we do ? As I would not want to go through the hassle of a maven publication: |
A GitHub package would be sufficient. |
We need a published artifact of metafacture-core to consume in metafacture-fix. A feature branch wouldn't help. |
Artifacts should be published to https://github.com/orgs/metafacture/packages?repo_name=metafacture-core in a few minutes. |
Now that the packages are up, maybe I spoke too soon. We can't (rather, shouldn't) depend on unstable versions. But as you said that a feature branch was acceptable for lobid-resources, you can work off of the WIP PR #266, right? |
Yes, working with a fetaure branch is ok for me. |
@TobiasNx can you do the functional review using the branch |
I try to set an integration test for this. But it seems not to work yet. @blackwinter could you have a look? |
Look where? What's not working? |
@blackwinter : I didn't push. Should be pushed now. Sorry. |
Thanks |
@blackwinter Introduced multi column lookup to metafacture morph. to use this in fix we need some additional options with
put_filemap()
metafacture/metafacture-core#471
The text was updated successfully, but these errors were encountered: