-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FileMap
options to put_filemap()
Fix function.
#266
Conversation
There seems to be an issue with the newly built metafacture-core artifacts (see metafacture/metafacture-core#473). All integration tests are failing:
|
Note that we've seen this error before in #90. |
Seems similar to hbz/lobid-resources#1462 - a conflict between different |
How do you figure? |
Because of your error message (how did you get this , btw - I only see that it fails). It's said there "NoSuchFieldError" and that reminded me. Also, locally build and consumed mf-master works, and |
True, but it's a different field. |
Ran it locally. Maybe we should change the integration tests to print errors to the console in CI. |
Yeah but xtext uses ANTLR. I am unsure - is there no connection? |
I don't know. Since we weren't able to identify the actual root cause in hbz/lobid-resources#1462 or any cause in #90, I really can't say. It's clearly reminiscent of the former (works in one environment, but not the other), so it might make sense to investigate in that direction. |
Done in 9ee2194. |
6b4f4b8
to
24647b6
Compare
This resolves "Caused by: java.lang.NoSuchFieldError: EOF_TOKEN at org.eclipse.xtext.parser.antlr.Lexer.nextToken(Lexer.java:60)" so that integration tests passes again.
24647b6
to
5edf835
Compare
@blackwinter : updated to a "stable" |
This resolves "Caused by: java.lang.NoSuchFieldError: EOF_TOKEN at org.eclipse.xtext.parser.antlr.Lexer.nextToken(Lexer.java:60)" so that integration tests pass again.
5edf835
to
08d992e
Compare
Thanks @dr0i. I can't say I particularly like the version pinning, but let's just move on I guess... Ready for review. |
Thx for correcting the commit.
Why?The underlying problem seems to be a conflicting dependency , i.e. the erratic choosing of an one of the two |
Because it's non-obvious (to me, at least). No dependencies have changed between 5.4.0 and 5.4.1-rc1, only the publishing process. I don't see anything erratic about it either, it's consistently selecting the wrong version - but only in the runner (integration tests), not in the library (unit tests). I don't understand it, pure and simple. |
From https://stackoverflow.com/questions/24962607/multiple-versions-of-the-same-dependency-in-maven :
My understanding (may be wrong - but "explains" the phenomenon): |
Both |
Oh, yes, you are correct.
in 255_broken.txt there is:
while in before266_allfine.txt there is:
So: why is there "3.5.2 (c)" using GithubPackages? |
@blackwinter can we merge this and resolve #265 ? |
Yes. We should probably do it in a dedicated issue, but I'm not sure what the right angle would be (I so desperately want Metafacture's Gradle build cleaned up, and also updated to a current Gradle version). And seeing as we already started here, let me just post another observation: The new publishing process (via --- metafacture-flux-uploadArchives-pom.xml 2022-11-15 14:39:31.375148909 +0100
+++ metafacture-flux-publishToMavenLocal-pom.xml 2022-11-15 14:39:15.143648173 +0100
@@ -63,6 +68,12 @@
<url>https://github.com/metafacture/metafacture-core/actions</url>
</ciManagement>
<dependencies>
+ <dependency>
+ <groupId>org.antlr</groupId>
+ <artifactId>antlr</artifactId>
+ <version>3.5.2</version>
+ <scope>compile</scope>
+ </dependency>
<dependency>
<groupId>org.metafacture</groupId>
<artifactId>metafacture-framework</artifactId>
@@ -81,17 +92,5 @@
<version>master-SNAPSHOT</version>
<scope>runtime</scope>
</dependency>
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.12</version>
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>org.metafacture</groupId>
- <artifactId>metafacture-plumbing</artifactId>
- <version>master-SNAPSHOT</version>
- <scope>test</scope>
- </dependency>
</dependencies>
</project> NOTE: I added the Maven project description to the new POM in order to reduce noise; but we should probably do it anyway if we want to preserve this information. [Done in metafacture/metafacture-core@d9a47e4.] |
Ah, that explains it! |
Well, not exactly. We still don't know why... (need to look into the |
...afacture/metafix/integration/lookup/fromJson/toJson/lookupSimpleWithMultiColumnFile/test.fix
Outdated
Show resolved
Hide resolved
83d1152
to
4a5e20f
Compare
4a5e20f
to
4a2b9ff
Compare
There are options that are unknown to me. I could add a documentation, if somebody explains their function to me.
|
Please note that I already added some |
I added some documentation. Reused some of the existing documentation and ignored |
Otherwise +1 from me concerning functional review. |
Thanks! Can you approve then? |
WIP until a stable metafacture-core release artifact becomes available.
Resolves #265.