Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action "publish to github packages" #473

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Oct 20, 2022

By pushing to a "publish" branch this branch will be build and published to github packages.

  • update README
  • update build.gradle
  • remove superflous task
  • remove unused travis configs

See metafacture-fix#265.

@dr0i
Copy link
Member Author

dr0i commented Oct 20, 2022

Todo: update documentation in the wiki.

Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! But it should be published to the Metafacture registry, not your personal one.

build.gradle Outdated Show resolved Hide resolved
@blackwinter blackwinter assigned dr0i and unassigned blackwinter Oct 20, 2022
By invoking "./gradlew publish" new github packages will be build
and published.

- update README
- update build.gradle
- remove superflous task
- remove unused travis configs

See metafacture-fix#265.
@dr0i dr0i force-pushed the metafacture-fix-265-publishToGithubPackages branch from 279a9e6 to bb7e3cf Compare October 20, 2022 15:44
Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dr0i dr0i merged commit 893e5b1 into master Oct 20, 2022
@dr0i dr0i deleted the metafacture-fix-265-publishToGithubPackages branch October 20, 2022 15:47
@fsteeg
Copy link
Member

fsteeg commented Oct 20, 2022

I'm a bit confused here. The version is feature-publish-SNAPSHOT (see package). Do we actually want an unspecific snapshot release? Even if we do, I don't think we'll be able to publish that version again, I think we'll have to (manually?) delete all the packages before we can publish again with the same version.

Before, I had it set up (not in master, I used these only for OERSI) to release only when we push to an RC branch, and use that simple branch name as the version. See 6613de9 (based on the original setup in 8d762ea). Resulting in versions like 5.3.3-rc2 (see package).

@blackwinter
Copy link
Member

I'm a bit confused here. The version is feature-publish-SNAPSHOT (see package). Do we actually want an unspecific snapshot release?

TBH, I wasn't expecting this either, but it's a side effect of the "sophisticated" version logic in metafacture-core. My suggestion would be to drop it and simply rely on explicit version numbers (as in metafacture-fix).

dr0i added a commit that referenced this pull request Oct 31, 2022
…of github.com:metafacture/metafacture-core
dr0i added a commit that referenced this pull request Oct 31, 2022
…of github.com:metafacture/metafacture-core
dr0i pushed a commit that referenced this pull request Nov 4, 2022
Use plain RC branch name as version during build.

See #356
@dr0i
Copy link
Member Author

dr0i commented Nov 4, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants