Add format support to nvme WipeDisk #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmlb
requested review from
joelrebel,
splaspood and
turegano-equinix
as code owners
|
depends on #136 |
This comment was marked as outdated.
This comment was marked as outdated.
mmlb
force-pushed
the
nvme-format
branch
2 times, most recently
from
5665654
to
5a7144b
Compare
mmlb
force-pushed
the
nvme-format
branch
3 times, most recently
from
9fd74ae
to
fbc982b
Compare
mmlb
changed the title
mmlb
force-pushed
the
nvme-format
branch
3 times, most recently
from
6b8af3f
to
3b665d1
Compare
turegano-equinix
requested changes
May 16, 2024
fixed |
turegano-equinix
approved these changes
May 17, 2024
mmlb
added a commit
to metal-toolbox/vogelkop
that referenced
this pull request
Jun 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/metal-toolbox/ironlib](https://togithub.com/metal-toolbox/ironlib) | `v0.2.18-0.20240611133518-3514176030a4` -> `v0.2.18` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>metal-toolbox/ironlib (github.com/metal-toolbox/ironlib)</summary> ### [`v0.2.18`](https://togithub.com/metal-toolbox/ironlib/releases/tag/v0.2.18) [Compare Source](https://togithub.com/metal-toolbox/ironlib/compare/v0.2.17...v0.2.18) #### What's Changed - Vc/instrument firmware by [@​DoctorVin](https://togithub.com/DoctorVin) in [metal-toolbox/ironlib#123 - Dockerfile: add support to build non-dist image by [@​joelrebel](https://togithub.com/joelrebel) in [metal-toolbox/ironlib#124 - Update actions/checkout action to v4 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#112 - House/spring cleaning by [@​mmlb](https://togithub.com/mmlb) in [metal-toolbox/ironlib#128 - ironlib is able to fill a disk with all zeros by [@​turegano-equinix](https://togithub.com/turegano-equinix) in [metal-toolbox/ironlib#131 - ironlib is able to detect ineffective wipes by [@​turegano-equinix](https://togithub.com/turegano-equinix) in [metal-toolbox/ironlib#135 - House Cleaning Part 2 - Electric Boogaloo! by [@​mmlb](https://togithub.com/mmlb) in [metal-toolbox/ironlib#133 - Better nvme capability detection by [@​mmlb](https://togithub.com/mmlb) in [metal-toolbox/ironlib#129 - Quiet down tests by [@​mmlb](https://togithub.com/mmlb) in [metal-toolbox/ironlib#137 - More refactors, fixes, etc by [@​mmlb](https://togithub.com/mmlb) in [metal-toolbox/ironlib#141 - chore(deps): update docker/login-action action to v3 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#118 - chore(deps): update docker/build-push-action action to v5 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#113 - fix(deps): update module github.com/r3labs/diff/v2 to v3 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#108 - chore(deps): update docker/metadata-action action to v5 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#144 - chore(deps): update actions/setup-go action to v5 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#143 - chore(deps): update module google.golang.org/protobuf to v1.33.0 \[security] by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#126 - fix(deps): update module golang.org/x/net to v0.23.0 \[security] by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#116 - chore(deps): update docker/setup-buildx-action action to v3 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#146 - fix(deps): update module github.com/sirupsen/logrus to v1.9.3 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#100 - chore(deps): update anchore/sbom-action action to v0.15.11 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#99 - fix(deps): update module github.com/tidwall/gjson to v1.17.1 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#109 - fix(deps): update module golang.org/x/net to v0.24.0 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#145 - chore(deps): update golangci/golangci-lint-action action to v5 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#147 - fix(deps): update module github.com/stretchr/testify to v1.9.0 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#101 - fix(deps): update module github.com/beevik/etree to v1.3.0 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#97 - fix(deps): update module golang.org/x/net to v0.25.0 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#148 - chore(deps): update github/codeql-action action to v3 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#149 - Update CODEOWNERS by [@​DoctorVin](https://togithub.com/DoctorVin) in [metal-toolbox/ironlib#152 - Update modules that renovate is having trouble with by [@​mmlb](https://togithub.com/mmlb) in [metal-toolbox/ironlib#150 - chore(deps): update golangci/golangci-lint-action action to v6 by [@​renovate](https://togithub.com/renovate) in [metal-toolbox/ironlib#153 - Add DiskWipe support to nvme using sanitize by [@​mmlb](https://togithub.com/mmlb) in [metal-toolbox/ironlib#136 - Add format support to nvme WipeDisk by [@​mmlb](https://togithub.com/mmlb) in [metal-toolbox/ironlib#142 - Add ns delete/create support to nvme WipeDisk by [@​mmlb](https://togithub.com/mmlb) in [metal-toolbox/ironlib#154 - More clean ups by [@​mmlb](https://togithub.com/mmlb) in [metal-toolbox/ironlib#158 - Add basic support for blkdiscard by [@​ScottGarman](https://togithub.com/ScottGarman) in [metal-toolbox/ironlib#159 - Some more clean ups by [@​mmlb](https://togithub.com/mmlb) in [metal-toolbox/ironlib#161 - Rename Disk stuff -> Drive and teach diskwipe example more tricks by [@​mmlb](https://togithub.com/mmlb) in [metal-toolbox/ironlib#163 #### New Contributors - [@​turegano-equinix](https://togithub.com/turegano-equinix) made their first contribution in [metal-toolbox/ironlib#131 - [@​ScottGarman](https://togithub.com/ScottGarman) made their first contribution in [metal-toolbox/ironlib#159 **Full Changelog**: metal-toolbox/ironlib@v0.2.17...v0.2.18 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/metal-toolbox/vogelkop). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Adds support for wiping nvme disks using nvme format for those devices that do not support sanitize.