ClayManagementToolbar #178
Conversation
…s not necesary to add it to the if.
…dItems and totalItems.
|
Just started reviewing :) |
Sent from 
| "babel-loader": "^7.0.0", | ||
| "babel-plugin-transform-node-env-inline": "^0.1.1", | ||
| "babel-preset-env": "^1.6.0", | ||
| "browserslist-config-clay-components": "^1.0.0-alpha.3", |
There was a problem hiding this comment.
Was this not to be 1.0.0-alpha.2?
There was a problem hiding this comment.
Yes, I changed, don't know why is again on alpha.3, I'm changing it!
| * Total number of items. | ||
| * @instance | ||
| * @memberof ClayManagementToolbar | ||
| * @type {?int} |
There was a problem hiding this comment.
Should to be {?number|undefined}? the default is undefined and validators is number.
| * Number of selected items. | ||
| * @instance | ||
| * @memberof ClayManagementToolbar | ||
| * @type {?number} |
There was a problem hiding this comment.
Should to be {?number|undefined}? the default is undefined.
| * List of items to display in the actions menu on active state. | ||
| * @instance | ||
| * @memberof ClayManagementToolbar | ||
| * @type {?Array} |
There was a problem hiding this comment.
Should to be {?array|undefined}? the default is undefined.
| * List of filter menu items. | ||
| * @instance | ||
| * @memberof ClayManagementToolbar | ||
| * @type {?Array} |
There was a problem hiding this comment.
Should to be {?array|undefined}? the default is undefined.
| * @param {!Event} event | ||
| * @private | ||
| */ | ||
| handleSelectPageCheckboxChanged_(event) { |
There was a problem hiding this comment.
SF: Method alphabetically ordered
| {@param? totalItems: number} | ||
|
|
||
| {let $navAttributes kind="attributes"} | ||
| class="management-bar management-bar-light navbar navbar-expand-md |
There was a problem hiding this comment.
Should the default style when active should not be management-bar-primary?
| </ul> | ||
|
|
||
| {if $actionItems} | ||
| <ul class="navbar-nav"> |
There was a problem hiding this comment.
Hey @carloslancha, is not it necessary to add Quick actions? defined by the lexicon team?
There was a problem hiding this comment.
I did not see the above comment, sorry 😅.
|
|
||
| {if $filterItems} | ||
| <li class="dropdown nav-item"> | ||
| {call ClayDropdown.render} |
There was a problem hiding this comment.
On the mobile this will disappear. Did you get to see that? By markup, it is necessary to add a second button...
There was a problem hiding this comment.
This is added to the missing stuff too
| * @type {?bool|undefined} | ||
| * @default undefined | ||
| */ | ||
| selectable: Config.bool(), |
There was a problem hiding this comment.
Could it be Config.bool().value(false)?
|
Merged. Thanks! |
Missing features: