allow namespace to continue with terminating when deprovisioning at t…

…he same time

print ns to easier tracing

allow namespace to continue with terminating when deprovisioning at the same time

controllers/metal3.io/baremetalhost_controller.go

@@ -757,10 +757,15 @@ func (r *BareMetalHostReconciler) registerHost(prov provisioner.Provisioner, inf
 		return actionError{err}
 	}
 	switch info.host.Status.Provisioning.State {
-	case metal3v1alpha1.StateRegistering, metal3v1alpha1.StateExternallyProvisioned:
+	case metal3v1alpha1.StateRegistering, metal3v1alpha1.StateExternallyProvisioned, metal3v1alpha1.StateDeleting:
 		// No need to create PreprovisioningImage if host is not yet registered
 		// or is externally provisioned
 		preprovImgFormats = nil
+	case metal3v1alpha1.StateDeprovisioning:
+		// PreprovisioningImage is not required for deprovisioning when cleaning is disabled
+		if info.host.Spec.AutomatedCleaningMode == metal3v1alpha1.CleaningModeDisabled {
+			preprovImgFormats = nil
+		}
 	}
 
 	preprovImg, err := r.getPreprovImage(info, preprovImgFormats)
@@ -832,9 +837,13 @@ func (r *BareMetalHostReconciler) registerHost(prov provisioner.Provisioner, inf
 
 	// Create the hostFirmwareSettings resource with same host name/namespace if it doesn't exist
 	if info.host.Name != "" {
-		if err = r.createHostFirmwareSettings(info); err != nil {
-			info.log.Info("failed creating hostfirmwaresettings")
-			return actionError{errors.Wrap(err, "failed creating hostFirmwareSettings")}
+		if !info.host.DeletionTimestamp.IsZero() {
+			r.Log.Info(fmt.Sprintf("will not attempt to create new hostFirmwareSettings in %s", info.host.Namespace))
+		} else {
+			if err = r.createHostFirmwareSettings(info); err != nil {
+				info.log.Info("failed creating hostfirmwaresettings")
+				return actionError{errors.Wrap(err, "failed creating hostFirmwareSettings")}
+			}
 		}
 	}
 
@@ -971,11 +980,17 @@ func (r *BareMetalHostReconciler) actionInspecting(prov provisioner.Provisioner,
 			return actionError{errors.Wrap(err, "failed to delete hardwareData")}
 		}
 	}
+
+	if !info.host.DeletionTimestamp.IsZero() {
+		info.log.Info(fmt.Sprintf("will not attempt to create hardwareData in %q", hd.Namespace))
+		return actionComplete{}
+	}
+
 	// either hardwareData was deleted above, or not found. We need to re-create it
 	if err := r.Client.Create(context.Background(), hd); err != nil {
 		return actionError{errors.Wrap(err, "failed to create hardwareData")}
 	}
-	info.log.Info(fmt.Sprintf("Created hardwareData %q in %q namespace\n", string(hd.Name), string(hd.Namespace)))
+	info.log.Info(fmt.Sprintf("Created hardwareData %q in %q namespace\n", hd.Name, hd.Namespace))
 
 	return actionComplete{}
 }