irmc: change the return value of NeedsMAC() to true

[zhouhao3]

When adding iRMC type BMH in OCP environment, if bootMACAddress is not specified, the following error will occur:

Events:                              
  Type    Reason             Age   From                         Message
  ----    ------             ----  ----                         -------
  Normal  RegistrationError  47s   metal3-baremetal-controller  MAC address  conflicts with existing node openshift-machine-api~master-0
  Normal  RegistrationError  47s   metal3-baremetal-controller  MAC address  conflicts with existing node openshift-machine-api~master-0

So modify the return value of NeedsMAC so that bootMACAddress must be specified when creating a BMH.

Signed-off-by: Zhou Hao zhouhao@fujitsu.com

[metal3-io-bot]

Hi @zhouhao3. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andfasano]

Hi @zhouhao3,
can you please add some description to the PR (and link an issue if present)? Thanks.

[zhouhao3]

@andfasano Updated, thanks.

[hardys]

/ok-to-test
/lgtm

[hardys]

lgtm but seems like the test failure is real

$ go test .
--- FAIL: TestStaticDriverInfo (0.00s)
    --- FAIL: TestStaticDriverInfo/irmc (0.00s)
        access_test.go:657: MAC needed: true , expected false
FAIL
FAIL	github.com/metal3-io/baremetal-operator/pkg/ironic/bmc	0.005s
FAIL

[zhouhao3]

updated, PTAL.

[zhouhao3]

/test-v1b1-centos-integration
/test-v1b1-integration

[dtantsur]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dtantsur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hardys]

/lgtm