Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove amd64 and linux to ensure multiarch container build #1097

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

jeffdyoung
Copy link
Contributor

Hello, I am testing the baremetal-operator on arm, and noticed that this builds an arm container with an x86 image. I'd like to remove the hard-coded arch so the image builds based on the os arch.

@metal3-io-bot
Copy link
Contributor

Hi @jeffdyoung. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2022
@jeffdyoung
Copy link
Contributor Author

/assign @andfasano

@yselkowitz
Copy link

/lgtm
/cc @elfosardo

@metal3-io-bot
Copy link
Contributor

@yselkowitz: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm
/cc @elfosardo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andfasano
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 22, 2022
@zaneb
Copy link
Member

zaneb commented Mar 22, 2022

Should this be done for https://github.com/metal3-io/baremetal-operator/blob/main/Tiltfile#L101 as well?

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2022
@dtantsur
Copy link
Member

/test-v1b1-centos-integration
/test-v1b1-ubuntu-integration
/lgtm

@metal3-io-bot metal3-io-bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Mar 22, 2022
@dtantsur
Copy link
Member

/test-v1b1-centos-integration
/test-v1b1-ubuntu-integration
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2022
@metal3-io-bot metal3-io-bot merged commit 49acfaa into metal3-io:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done / Closed
Development

Successfully merging this pull request may close these issues.

6 participants