🌱 Improve webhook verification

apis/metal3.io/v1alpha1/baremetalhost_validation.go

@@ -3,6 +3,7 @@ package v1alpha1
 import (
 	"fmt"
 	"net"
+	"net/url"
 	"regexp"
 
 	"github.com/google/uuid"
@@ -43,6 +44,12 @@ func (host *BareMetalHost) validateHost() []error {
 		errs = append(errs, err)
 	}
 
+	if host.Spec.Image != nil {
+		if err := validateImageURL(host.Spec.Image.URL); err != nil {
+			errs = append(errs, err)
+		}
+	}
+
 	return errs
 }
 
@@ -69,6 +76,7 @@ func (host *BareMetalHost) validateChanges(old *BareMetalHost) []error {
 
 func validateBMCAccess(s BareMetalHostSpec, bmcAccess bmc.AccessDetails) []error {
 	var errs []error
+	diskFormat := "live-iso"
 
 	if bmcAccess == nil {
 		return errs
@@ -101,6 +109,10 @@ func validateBMCAccess(s BareMetalHostSpec, bmcAccess bmc.AccessDetails) []error
 		errs = append(errs, fmt.Errorf("BMC driver %s does not support secure boot", bmcAccess.Type()))
 	}
 
+	if s.Image != nil && s.Image.DiskFormat != nil && *s.Image.DiskFormat == diskFormat && !bmcAccess.SupportsISOPreprovisioningImage() {
+		errs = append(errs, fmt.Errorf("BMC driver %s does not support live-iso image", bmcAccess.Type()))
+	}
+
 	return errs
 }
 
@@ -162,3 +174,13 @@ func validateDNSName(hostaddress string) error {
 
 	return nil
 }
+
+func validateImageURL(imageURL string) error {
+
+	_, err := url.ParseRequestURI(imageURL)
+	if err != nil {
+		return fmt.Errorf("Image URL %s is an invalid URL", imageURL)
+	}
+
+	return nil
+}

apis/metal3.io/v1alpha1/baremetalhost_validation_test.go

@@ -46,6 +46,7 @@ func TestValidateCreate(t *testing.T) {
 
 	// for RAID validation test cases
 	numberOfPhysicalDisks := 3
+	diskFormat := "live-iso"
 
 	tests := []struct {
 		name      string
@@ -437,6 +438,43 @@ func TestValidateCreate(t *testing.T) {
 			oldBMH:    nil,
 			wantedErr: "BMO validation: failed to parse BMC address information: BMC address hostname/IP : [fe80::fc33:62ff:fe33:8xff] is invalid",
 		},
+		{
+			name: "invalidImageURL",
+			newBMH: &BareMetalHost{
+				TypeMeta:   tm,
+				ObjectMeta: om,
+				Spec: BareMetalHostSpec{
+					BMC: BMCDetails{
+						Address:         "idrac://127.0.0.1",
+						CredentialsName: "test1",
+					},
+					Image: &Image{
+						URL: "test1",
+					},
+				},
+			},
+			oldBMH:    nil,
+			wantedErr: "Image URL test1 is an invalid URL",
+		},
+		{
+			name: "liveISOImageWithUnsupportedBMC",
+			newBMH: &BareMetalHost{
+				TypeMeta:   tm,
+				ObjectMeta: om,
+				Spec: BareMetalHostSpec{
+					BMC: BMCDetails{
+						Address:         "idrac://127.0.0.1",
+						CredentialsName: "test1",
+					},
+					Image: &Image{
+						URL:        "http://127.0.0.1",
+						DiskFormat: &diskFormat,
+					},
+				}, // end of BMH spec
+			},
+			oldBMH:    nil,
+			wantedErr: "BMC driver idrac does not support live-iso image",
+		},
 	}
 
 	for _, tt := range tests {