Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Improve webhook verification #1107

Merged
merged 3 commits into from
Aug 16, 2022
Merged

馃尡 Improve webhook verification #1107

merged 3 commits into from
Aug 16, 2022

Conversation

zhouhao3
Copy link
Member

@zhouhao3 zhouhao3 commented Apr 11, 2022 •
edited

Part of #855

  • Add validations for ImageUrl
  • Add validations for Image.DiskFormat

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 11, 2022
@zhouhao3
Copy link
Member Author

/test-v1b1-centos-integration
/test-v1b1-ubuntu-integration

@zhouhao3 zhouhao3 changed the title Add validations for ImageUrl Improve weebhook verification Apr 12, 2022
@zhouhao3
Copy link
Member Author

/test-v1b1-centos-integration
/test-v1b1-ubuntu-integration

@zhouhao3 zhouhao3 changed the title Improve weebhook verification Improve webhook verification Apr 13, 2022
@zhouhao3
Copy link
Member Author

/cc @zaneb @andfasano

@zhouhao3
Copy link
Member Author

@elfosardo @dtantsur PTAL

@zhouhao3
Copy link
Member Author

/test-centos-integration-main
/test-ubuntu-integration-main

@zhouhao3
Copy link
Member Author

@furkatgofurov7 @fmuyassarov PTAL, thanks!

@zhouhao3
Copy link
Member Author

zhouhao3 commented Aug 1, 2022

@dtantsur @fmuyassarov @elfosardo This PR has been stuck for a long time, please take a look if you have time. Thanks.

fmuyassarov
fmuyassarov reviewed Aug 1, 2022
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

apis/metal3.io/v1alpha1/baremetalhost_validation.go Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2022
@zhouhao3
Copy link
Member Author

zhouhao3 commented Aug 1, 2022

/test-centos-integration-main
/test-ubuntu-integration-main

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2022
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2022
@zhouhao3
Copy link
Member Author

zhouhao3 commented Aug 5, 2022

/test-centos-integration-main
/test-ubuntu-integration-main

@zhouhao3 zhouhao3 force-pushed the add-image-url-validate branch 2 times, most recently from e4e6ec0 to 4f92f5f Compare August 5, 2022 05:36
@zhouhao3
Copy link
Member Author

zhouhao3 commented Aug 5, 2022

/test-centos-integration-main
/test-ubuntu-integration-main

@zhouhao3
Copy link
Member Author

@honza @furkatgofurov7 PTAL

@zhouhao3
Add validations for ImageURL
db8d5cc 
Signed-off-by: Zhou Hao <zhouhao@fujitsu.com>
@zhouhao3 zhouhao3 force-pushed the add-image-url-validate branch 2 times, most recently from 71ba67d to fe0a466 Compare August 15, 2022 08:22
@zhouhao3
Copy link
Member Author

/test-centos-integration-main
/test-ubuntu-integration-main

@zhouhao3
Add UT for validateImageUrl
fe77c15 
Signed-off-by: Zhou Hao <zhouhao@fujitsu.com>
@zhouhao3
Add validations for Image.DiskFormat
4098675 
Signed-off-by: Zhou Hao <zhouhao@fujitsu.com>
@zhouhao3
Copy link
Member Author

/test-centos-integration-main
/test-ubuntu-integration-main

@furkatgofurov7
Copy link
Member

test-centos-integration-main
test-ubuntu-integration-main

We are currently experiencing some issues with CI infra and until that is resolved tests can not be triggered. xref slack: https://kubernetes.slack.com/archives/CHD49TLE7/p1660545818115799

@zhouhao3
Copy link
Member Author

/test-centos-integration-main
/test-ubuntu-integration-main

furkatgofurov7
furkatgofurov7 approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2022
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit b2faf61 into metal3-io:main Aug 16, 2022
@lentzi90 lentzi90 mentioned this pull request Aug 18, 2022
Closed
@furkatgofurov7 furkatgofurov7 changed the title Improve webhook verification 馃尡 Improve webhook verification Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

@andfasano andfasano Awaiting requested review from andfasano

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhouhao3 @furkatgofurov7 @metal3-io-bot @fmuyassarov