Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Expose FirmwareInterface in Node/BMC #1441

Merged
merged 1 commit into from Nov 22, 2023
Merged

✨ Expose FirmwareInterface in Node/BMC #1441

merged 1 commit into from Nov 22, 2023

Conversation

iurygregory
Copy link
Member

@iurygregory iurygregory commented Nov 10, 2023 •
edited

Ironic introduced a new interface called Firmware Interface This commit aims to addapt existing code to support creating nodes with the new field.

  • Rename "firmwareUpgrades" to "firmwareUpdates", since this
    can be used for upgrades and downgrades.
  • gophercloud updated to a newer version
  • go get -v github.com/gophercloud/gophercloud@master
  • go mod tidy
  • All BMCs have now FirmwareInterface() with default values
  • Ironic provisioner updated to receive FirmwareInterface when creating a node

What this PR does / why we need it:
Exposes the firmware interface field that was introduced in ironic and will help in future work of metal3-io/metal3-docs#364

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 10, 2023
@iurygregory
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@iurygregory
Copy link
Member Author

/test-centos-e2e-integration-main

@iurygregory
Copy link
Member Author

/test-centos-e2e-integration-main

@iurygregory
Copy link
Member Author

/test-ubuntu-integration-main

dtantsur
dtantsur reviewed Nov 20, 2023
View reviewed changes
docs/configuration.md Outdated Show resolved Hide resolved
@iurygregory
Copy link
Member Author

/test golint
Seems like a timeout from the logs

@iurygregory
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@iurygregory
Copy link
Member Author

/retest
to trigger another run for E2E Fixture Test

@iurygregory
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

dtantsur
dtantsur previously requested changes Nov 21, 2023
View reviewed changes
pkg/provisioner/ironic/ironic.go Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2023
@iurygregory
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@iurygregory
Support FirmwareInterface
7baa4bb 
Ironic introduced a new interface called Firmware Interface
This commit aims to addapt existing code to support creating
nodes with the new field.

- Rename "firmwareUpgrades" to "firmwareUpdates", since this
  can be used for upgrades and downgrades.
- gophercloud updated to a newer version
* go get -v github.com/gophercloud/gophercloud@master
* go mod tidy
- All BMCs have now FirmwareInterface() with default values
- Ironic provisioner updated to receive FirmwareInterface when creating
a node

Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
@iurygregory
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2023
@dtantsur dtantsur dismissed their stale review November 22, 2023 12:03

github UI is crap

@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2023
@metal3-io-bot metal3-io-bot merged commit 1498f19 into metal3-io:main Nov 22, 2023
14 checks passed
@Rozzii Rozzii mentioned this pull request Dec 19, 2023
Closed
@iurygregory iurygregory deleted the firmware-interface-node branch February 6, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iurygregory @dtantsur @metal3-io-bot @elfosardo