Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firmware Interface proposal #364

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Firmware Interface proposal #364

merged 1 commit into from
Nov 21, 2023

Conversation

iurygregory
Copy link
Member

No description provided.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 17, 2023
@tuminoid
Copy link
Member

/retitle Firmware Interface proposal

@metal3-io-bot metal3-io-bot changed the title Firwmare Interface proposal Firmware Interface proposal Oct 26, 2023
elfosardo
elfosardo reviewed Nov 8, 2023
View reviewed changes
design/baremetal-operator/firmware-interface.md Outdated Show resolved Hide resolved
design/baremetal-operator/firmware-interface.md Outdated Show resolved Hide resolved
design/baremetal-operator/firmware-interface.md Outdated Show resolved Hide resolved
design/baremetal-operator/firmware-interface.md Outdated Show resolved Hide resolved
design/baremetal-operator/firmware-interface.md Outdated Show resolved Hide resolved
design/baremetal-operator/firmware-interface.md Outdated Show resolved Hide resolved
design/baremetal-operator/firmware-interface.md Outdated Show resolved Hide resolved
@iurygregory iurygregory force-pushed the firmware-interface branch 2 times, most recently from 986081e to 8cd2a4b Compare November 9, 2023 13:43
@iurygregory iurygregory mentioned this pull request Nov 10, 2023
Merged
@iurygregory
Copy link
Member Author

@elfosardo @dtantsur if you think I need to update more things here, let me know.

dtantsur
dtantsur reviewed Nov 20, 2023
View reviewed changes
design/baremetal-operator/firmware-interface.md
- Verify that updates can be executed on two type of hardware that supports
Redfish.
- Verify that the information about the desired version is available after
cleaning.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BMO has new e2e tests (check the commit history). That allows us to test firmware upgrades against sushy-tools. WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hummm that could be a thing, but sushy-tools currently doesn't have the capability to execute firmware updates.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mquhuy @mboukhalfa This might be interesting feature for you to implement in susy tools or to anyone in our team @kashifest

@dtantsur
Copy link
Member

/approve

I think we're at the point where the details can be polished in the code (but I'd still appreciate my comments addressed).

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023
@iurygregory
Firwmare Interface proposal
9da24dc 
Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
Rozzii
Rozzii approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I like this feature very much, from my POV it is a go!

design/baremetal-operator/firmware-interface.md
- Verify that updates can be executed on two type of hardware that supports
Redfish.
- Verify that the information about the desired version is available after
cleaning.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mquhuy @mboukhalfa This might be interesting feature for you to implement in susy tools or to anyone in our team @kashifest

@Rozzii
Copy link
Member

Rozzii commented Nov 21, 2023

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 139cc62 into metal3-io:main Nov 21, 2023
6 checks passed
iurygregory added a commit to iurygregory/baremetal-operator that referenced this pull request Dec 29, 2023
@iurygregory
Add new CRD for Firmware Components Update
e330df0 
Add a new CRD for the HostFirmwareComponents described
in the Firmware Interface proposal - metal3-io/metal3-docs#364.
iurygregory added a commit to iurygregory/baremetal-operator that referenced this pull request Dec 29, 2023
@iurygregory
Add new CRD for Firmware Components Update
8d79121 
Add a new CRD for the HostFirmwareComponents described
in the Firmware Interface proposal - metal3-io/metal3-docs#364.

Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
@iurygregory iurygregory mentioned this pull request Dec 29, 2023
Merged
iurygregory added a commit to iurygregory/baremetal-operator that referenced this pull request Jan 15, 2024
@iurygregory
Add new CRD for Firmware Components Update
a0fa687 
Add a new CRD for the HostFirmwareComponents described
in the Firmware Interface proposal - metal3-io/metal3-docs#364.

Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
iurygregory added a commit to iurygregory/baremetal-operator that referenced this pull request Jan 15, 2024
@iurygregory
Add new CRD for Firmware Components Update
d89e8ad 
Add a new CRD for the HostFirmwareComponents described
in the Firmware Interface proposal - metal3-io/metal3-docs#364.

Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
iurygregory added a commit to iurygregory/baremetal-operator that referenced this pull request Jan 18, 2024
@iurygregory
Add new CRD for Firmware Components Update
9584a9b 
Add a new CRD for the HostFirmwareComponents described
in the Firmware Interface proposal - metal3-io/metal3-docs#364.

Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
iurygregory added a commit to iurygregory/baremetal-operator that referenced this pull request Jan 18, 2024
@iurygregory
Add new CRD for Firmware Components Update
7a29244 
Add a new CRD for the HostFirmwareComponents described
in the Firmware Interface proposal - metal3-io/metal3-docs#364.

Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
@iurygregory iurygregory mentioned this pull request Feb 15, 2024
Merged
@iurygregory iurygregory mentioned this pull request Apr 8, 2024
Merged
@iurygregory iurygregory mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur left review comments

@elfosardo elfosardo elfosardo left review comments

@Rozzii Rozzii Rozzii approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@iurygregory @tuminoid @dtantsur @Rozzii @metal3-io-bot @elfosardo