✨ Add Golang-based deploy-cli

[mquhuy]

What this PR does / why we need it:
This package does the jobs that are currently handled by deploy.sh. It will help installing BMO, Ironic with suitable configuration.

This PR has been successfully tested here: metal3-io/metal3-dev-env#1447

Co-author: @maxrantil

[kashifest]

cc @adilGhaffarDev @lentzi90 @Rozzii @kashifest

[Rozzii]

/cc @dtantsur @elfosardo @zaneb I think you would like to check this out also

[metal3-io-bot]

@Rozzii: GitHub didn't allow me to request PR reviews from the following users: I, to, out, check, this, also, would, like, you, think.

Note that only metal3-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @dtantsur @elfosardo @zaneb I think you would like to check this out also

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mquhuy]

/test metal3-bmo-e2e-test-pull

[mquhuy]

cc @adilGhaffarDev @lentzi90 @Rozzii @kashifest

/cc @adilGhaffarDev @lentzi90 @Rozzii @kashifest
Just so that you guys are added to reviewers list

[mquhuy]

I was rather thinking that we make this one replace deploy.sh after we've cut 0.7, so it gets tested in CI for a release cycle as primary tool, and there wouldn't be two tools to maintain.

How does that sound?

Yep that would be great! We will have to do that change in dev-env though, so doesn't matter if we merge this PR or not.

[tuminoid]

I was rather thinking that we make this one replace deploy.sh after we've cut 0.7, so it gets tested in CI for a release cycle as primary tool, and there wouldn't be two tools to maintain.
How does that sound?

Yep that would be great! We will have to do that change in dev-env though, so doesn't matter if we merge this PR or not.

Yes I'm aware of that. However we need to maintain this in 0.7 if we merge it before cutting release, so I think we are agreeing on merging only after 0.7?

[mquhuy]

Yes I'm aware of that. However we need to maintain this in 0.7 if we merge it before cutting release, so I think we are agreeing on merging only after 0.7?

Yeah let's merge after 0.7 then

[mquhuy]

/unhold We have BMO 0.8 released.

[mquhuy]

/unhold

[kashifest]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kashifest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tuminoid]

Some nits

[Rozzii]

In general the structure and the approach looks good.
It is a quite a bit of code to verify the workflow just by looking at it so I guess we will see the issues and edge cases after we start using this in CI or in local dev-env.
I am willing to put lgtm on this after the nits and branch conflict has been resolved

[mquhuy]

In general the structure and the approach looks good. It is a quite a bit of code to verify the workflow just by looking at it so I guess we will see the issues and edge cases after we start using this in CI or in local dev-env. I am willing to put lgtm on this after the nits and branch conflict has been resolved

Thank you. Of course we can only make sure how well it works after it's in CI, but at least we were able to test it in this PR: metal3-io/metal3-dev-env#1447

[tuminoid]

/lgtm

I'll put a hold until the final run of tests in the dev-env PR passes.
/hold

[mquhuy]

Tests passed
/unhold