Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade module to Golang 1.14, and tidy modules #557

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Upgrade module to Golang 1.14, and tidy modules #557

merged 2 commits into from
Jun 17, 2020

Conversation

honza
Copy link
Member

@honza honza commented Jun 16, 2020

No description provided.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 16, 2020
@honza honza mentioned this pull request Jun 16, 2020
Merged
@honza
Copy link
Member Author

honza commented Jun 16, 2020

/test-integration

@dhellmann
Copy link
Member

This change looks fine, but a little more detail in the commit message about why the change is needed would be good.

@honza
Copy link
Member Author

honza commented Jun 16, 2020

This change looks fine, but a little more detail in the commit message about why the change is needed would be good.

OK, I can certainly add some. I was hesitant because it was driven by a downstream requirement.

@dhellmann
Copy link
Member

This change looks fine, but a little more detail in the commit message about why the change is needed would be good.

OK, I can certainly add some. I was hesitant because it was driven by a downstream requirement.

That's OK, just explaining the benefit in general terms would cover it.

@honza
Upgrade go module to golang 1.14
f8b49b2 
Golang 1.14 introduces new defaults around modules, namely the -mod
flag.  If a vendor directory is present, it will be used; if it's not,
the new go module system will be used.  This will allow us to build this
module in a variety of environments without changing our build scripts.
@honza
Tidy go modules
c14d773 
Golang 1.14 introduces some small changes to the semantics of the go.mod
file so we are updating it to reflect that (this is done with `go mod
tidy`, not by hand.).
@honza
Copy link
Member Author

honza commented Jun 16, 2020

That's OK, just explaining the benefit in general terms would cover it.

Done 💥

@dhellmann
Copy link
Member

/test-integration
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2020
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza, maelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2020
@metal3-io-bot metal3-io-bot merged commit 0acd7ec into metal3-io:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maelk maelk maelk approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@honza @dhellmann @metal3-io-bot @maelk