Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live-iso e2e test broken due to validation webhook #689

Closed
lentzi90 opened this issue Aug 18, 2022 · 4 comments
Closed

Live-iso e2e test broken due to validation webhook #689

lentzi90 opened this issue Aug 18, 2022 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@lentzi90
Copy link
Member

What steps did you take and what happened:

Run the parallel e2e test: /test-ubuntu-e2e-parallel-main
The live-iso test fails with this:

• Failure [0.090 seconds]
When testing live iso [live-iso]
/home/****/tested_repo/test/e2e/live_iso_test.go:16
  Should update the BMH with live ISO [It]
  /home/****/tested_repo/test/e2e/live_iso_test.go:30

  Unexpected error:
      <*errors.StatusError | 0xc000c0c140>: {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "admission webhook \"baremetalhost.metal3.io\" denied the request: BMC driver ipmi does not support live-iso image",
              Reason: "BMC driver ipmi does not support live-iso image",
              Details: nil,
              Code: 403,
          },
      }
      admission webhook "baremetalhost.metal3.io" denied the request: BMC driver ipmi does not support live-iso image
  occurred

What did you expect to happen:

No error should happen.

Anything else you would like to add:

This is most likely due to metal3-io/baremetal-operator#1107
But it is unclear if the issue is in the test itself, in the validation webhook or somewhere else.

Initially I thought that filtering for BMHs that are controlled using redfish (instead of ipmi) would solve the issue. But this is not the case.
See #688

/kind bug

@metal3-io-bot metal3-io-bot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Aug 18, 2022
@dtantsur
Copy link
Member

BMC driver ipmi does not support live-iso image

Is a valid error: IPMI cannot be used with live-iso. We need to use redfish-virtualmedia or another virtual media based driver.

@dtantsur
Copy link
Member

/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Aug 24, 2022
@lentzi90
Copy link
Member Author

Fixed by #690
/close

@metal3-io-bot
Copy link
Contributor

@lentzi90: Closing this issue.

In response to this:

Fixed by #690
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants