🌱 Standardize controller & baremetal unit test syntax #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/XL
Rozzii
changed the title
Rozzii
force-pushed
the
syntax_improve_adam
branch
from
7497ccf
to
1fa28ae
Compare
|
/test-v1b1-integration |
kashifest
approved these changes
Jan 26, 2022
metal3-io-bot
added
the
approved
macaptain
approved these changes
Jan 26, 2022
Rozzii
changed the title
lentzi90
approved these changes
Jan 26, 2022
metal3-io-bot
added
the
needs-rebase
This commit removes:
- unnecessary 'fakeclient' import alias
- unnecessary variable declarations
This commit also replaces the previously used variable name 'c'
with the 'fakeClient' name as it is more descriptive and it is also
used in CAPI.
This commit also breaks up some long lines in order to make them more
readable.
Rozzii
force-pushed
the
syntax_improve_adam
branch
from
1fa28ae
to
1cf2c5a
Compare
metal3-io-bot
removed
the
needs-rebase
|
/test-v1b1-integration |
lentzi90
approved these changes
Feb 1, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest, lentzi90, macaptain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes:
- unnecessary 'fakeclient' import alias
- unnecessary variable declarations
This commit also replaces the previously used variable name 'c'
with the 'fakeClient' name as it is more descriptive and it is also
used in CAPI.
This commit also breaks up some long lines in order to make them more
readable.